This repository was archived by the owner on Jan 20, 2024. It is now read-only.
ApiDefinition: Fix Deprecated warning on empty schema#181
Open
adriendupuis wants to merge 1 commit intoraml-org:masterfrom
Open
ApiDefinition: Fix Deprecated warning on empty schema#181adriendupuis wants to merge 1 commit intoraml-org:masterfrom
adriendupuis wants to merge 1 commit intoraml-org:masterfrom
Conversation
According to line 815, empty schema is supported. "PHP Deprecated: mb_strtoupper(): Passing null to parameter raml-org#1 ($string) of type string is deprecated in /Users/adriendupuis/www/developer-documentation/tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813"
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to line 815, empty schema is supported. This update avoids passing
nullwhen$this->baseUridoesn't have a scheme/schema from\parse_url($this->baseUri, PHP_URL_SCHEME)tomb_strtoupper.To reproduce:
baseUriin your RAML configuration ($this->baseUriisnull).baseUriwithout schema, likebaseUri: //api.example.com/{version}.Fix
PHP Deprecated: mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/adriendupuis/www/developer-documentation/tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813