Update Rancher Icons release to use trusted providers#101
Open
rak-phillip wants to merge 1 commit intorancher:masterfrom
Open
Update Rancher Icons release to use trusted providers#101rak-phillip wants to merge 1 commit intorancher:masterfrom
rak-phillip wants to merge 1 commit intorancher:masterfrom
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip
commented
Dec 12, 2025
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '14.x' | ||
| node-version: '20' |
Member
Author
There was a problem hiding this comment.
We will need to test to confirm that this works with node 20.
| fi | ||
|
|
||
| # Publish to npm if a node auth token is set in the environment | ||
| if [ -n "${NODE_AUTH_TOKEN}" ]; then |
Member
Author
There was a problem hiding this comment.
I don't know why we originally had this conditional clause for publishing. We might need to do some debugging to find the proper environment variable for the trusted publishing method if we need this back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Rancher Icons release to use trusted providers instead of the npm token.
Occurred changes and/or fixed issues
Technical notes summary
See the trusted publishing docs on npm1. This is now the preferred approach to publishing packages.
This work is part of a larger effort to move away from tokens. See prior Dashboard work:
rancher/dashboard#16157
rancher/dashboard#16166
Areas or cases that should be tested
After merge, release a new version of Rancher Icons.
Areas which could experience regressions
Publishing Rancher Icons.
Screenshot/Video
NA
Footnotes
https://docs.npmjs.com/trusted-publishers ↩