Open
Conversation
Abhishek-Valaboju
force-pushed
the
aks-1.7
branch
2 times, most recently
from
4e9beea to
2fd5212
Compare
Abhishek-Valaboju
force-pushed
the
aks-1.7
branch
from
2fd5212 to
2c0769a
Compare
mitulshah-suse
previously approved these changes
Feb 24, 2026
andypitcher
requested changes
Feb 25, 2026
Contributor
andypitcher
left a comment
andypitcher
left a comment
There was a problem hiding this comment.
LGTM, just added a small suggestion regarding the configmap for aks profiles, if you could adapt it.
| "aks-1.0": | ||
| - "node" | ||
| "aks-1.7": | ||
| - "node" |
Contributor
There was a problem hiding this comment.
Suggested change
| - "node" | |
| - "master" | |
| - "node" | |
| - "controlplane" | |
| - "policies" | |
| - "managedservices" |
As per upstream's configmap it seems that we're missing targets (even for aks-1.0).
Contributor
There was a problem hiding this comment.
@andypitcher node is the only target that we keep, since AKS control plane is managed by Azure and the scanner does not have access to verify those settings.
Co-authored-by: Andy Pitcher <andy.pitcher@suse.com>
andypitcher
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: rancher/rancher#53866
added aks 1.7 support