[Main] Move auth package to the clients to make it auth client, Auth Client Init Changes#248
Open
caliskanugur wants to merge 1 commit intorancher:mainfrom
Open
[Main] Move auth package to the clients to make it auth client, Auth Client Init Changes#248caliskanugur wants to merge 1 commit intorancher:mainfrom
caliskanugur wants to merge 1 commit intorancher:mainfrom
Conversation
Member
caliskanugur
commented
Aug 5, 2024
caliskanugur
commented
- Moves auth package to clients
- Adds auth as a client to the rancher.Client - uses management client mainly, and uses the same session instantiated for the clients
- Adds a new function to refresh provider access group in users
- Adds update method to OLDAP
caliskanugur
requested review from
Priyashetty17,
anupama2501,
dasarinaidu,
igomez06 and
joesims22
caliskanugur
force-pushed
the
qa-issue-1315
branch
from
48b74a4 to
5a4f296
Compare
igomez06
reviewed
Aug 22, 2024
Contributor
igomez06
left a comment
igomez06
left a comment
There was a problem hiding this comment.
Needs an update after last PR, but LGTM
anupama2501
approved these changes
Oct 17, 2024
Contributor
|
Have a few conflicts. could you rebase please. |
dasarinaidu
previously approved these changes
Apr 8, 2025
Contributor
dasarinaidu
left a comment
dasarinaidu
left a comment
There was a problem hiding this comment.
LGTM, please rebase and merge. Thanks
caliskanugur
dismissed stale reviews from dasarinaidu and joesims22
via
715baab
caliskanugur
force-pushed
the
qa-issue-1315
branch
from
5a4f296 to
715baab
Compare
…existing login method default to local provider, add a new function to refresh group for users
caliskanugur
force-pushed
the
qa-issue-1315
branch
from
715baab to
d0ff98f
Compare
Member
Author
|
Rebased from 83 commits:
Since there were so many changes that happened to both Shepherd and Clients, this PR is no longer safe to merge before the sanity checks. After sanity checks for the tests that use this PR are provided, we can review this PR, assigning you to this PR @dasarinaidu since we discussed the test part of this offline |
igomez06
reviewed
Apr 11, 2025
Contributor
igomez06
left a comment
igomez06
left a comment
There was a problem hiding this comment.
Will wait on sanity checks per Ugur's message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.