Updates to the following golang test framework extensions: defaults, kubeconfig, and provisioning#30
Open
git-ival wants to merge 2 commits intorancher:mainfrom
Open
Updates to the following golang test framework extensions: defaults, kubeconfig, and provisioning#30git-ival wants to merge 2 commits intorancher:mainfrom
git-ival wants to merge 2 commits intorancher:mainfrom
Conversation
This was referenced Feb 27, 2024
git-ival
force-pushed
the
update-extensions-misc
branch
2 times, most recently
from
3214384 to
a54ff3f
Compare
git-ival
added
the
automation-enhancement
git-ival
force-pushed
the
update-extensions-misc
branch
3 times, most recently
from
72c3e59 to
06e5fe0
Compare
git-ival
force-pushed
the
update-extensions-misc
branch
from
06e5fe0 to
d7dd482
Compare
igomez06
reviewed
Jul 5, 2024
git-ival
force-pushed
the
update-extensions-misc
branch
from
d5be1ca to
82ba209
Compare
igomez06
reviewed
Jul 24, 2024
| return logs, nil | ||
| } | ||
|
|
||
| func GetPodLogsWithOpts(client *rancher.Client, clusterID string, podName string, namespace string, bufferSizeStr string, opts *corev1.PodLogOptions) (string, error) { |
Contributor
There was a problem hiding this comment.
Can you add a go doc comment here?
igomez06
reviewed
Jul 24, 2024
Contributor
igomez06
left a comment
igomez06
left a comment
There was a problem hiding this comment.
looks good just add some go doc comments and we're good.
| k8Scheme "k8s.io/client-go/kubernetes/scheme" | ||
| ) | ||
|
|
||
| func GetPods(client *rancher.Client, clusterID string, namespace string, listOptions *metav1.ListOptions) ([]corev1.Pod, error) { |
Contributor
There was a problem hiding this comment.
Same with the functions here.
git-ival
force-pushed
the
update-extensions-misc
branch
from
6746674 to
0c61553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
Solution
extensions/kubeconfigextensions/kubeconfigTesting
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations