Update the rancher dynamic client to use its concrete struct types#31
Open
git-ival wants to merge 2 commits intorancher:mainfrom
Open
Update the rancher dynamic client to use its concrete struct types#31git-ival wants to merge 2 commits intorancher:mainfrom
git-ival wants to merge 2 commits intorancher:mainfrom
Conversation
caliskanugur
reviewed
Feb 5, 2024
Member
caliskanugur
left a comment
There was a problem hiding this comment.
Looks solid, I've got a few questions and a naming nit
5273d52 to
a69be5a
Compare
Member
Author
|
@caliskanugur Anything else needed on my end before this can be reviewed? |
This was referenced Feb 27, 2024
dd44042 to
ab92c36
Compare
igomez06
previously approved these changes
Mar 29, 2024
Contributor
igomez06
left a comment
There was a problem hiding this comment.
LGTM I think this looks good, we'll need to merge this as separate version bump, just to make sure there aren't any regressions in rancher.
9f9566e to
dd1fea2
Compare
dd1fea2 to
242ed8b
Compare
242ed8b to
6c67e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
As a developer attempting to debug issues while using the dynamic client, it was difficult to follow what code implemented the underlying functions. This was due to the dynamic client functions returning the upstream k8s dynamic client types instead of the concrete ones of the rancher dynamic client.
Solution
Update the dynamic client and other references to it so that they reference the concrete rancher dynamic client types.
Testing
Was able to build locally, have not run any tests from the rancher/rancher repo that might utilize the dynamic client. Custom tests utilizing the rancher dynamic client were able to run successfully and made debugging a bit easier.
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
There should not be regressions as this is a minor change that updates the types to the concrete ones provided in the rancher dynamic client code.
Existing / newly added automated tests that provide evidence there are no regressions: N/A