Refactor by t0kubetsu · Pull Request #62 · range42/range42-backend-api

t0kubetsu · 2026-03-23T10:06:59Z

No description provided.

closes #58) Default unchanged: localhost/127.0.0.1/[::1] only. Set CORS_ORIGIN_REGEX env var to allow additional origins, e.g.: CORS_ORIGIN_REGEX=^https?://(localhost|127\.0\.0\.1|\[::1\]|192\.168\.42\.\d+)(:\d+)?$

New endpoint: ws://host:8000/ws/vm-status?node=X&api_host=X&token_id=X&token_secret=X - Polls Proxmox API directly via httpx (fast, no Ansible overhead) - Sends full VM state on first connect - Sends only diffs (status/CPU changes) on subsequent updates - Filters out templates - 5-second poll interval - Auto-cleanup on disconnect

WebSocket endpoint now reads API host, token ID, and token secret from the backend's own inventory/hosts.yml file. Frontend only needs to connect to ws://backend/ws/vm-status — no credentials in the browser.

)

Add 9 consolidated schema files under app/schemas/: - base.py: ProxmoxBaseRequest added - vms.py: VM list, create, delete, clone, action, mass ops - vm_config.py: VM config get/set (full, cdrom, cpu, ram, tag) - snapshots.py: Snapshot CRUD (create, delete, list, revert) - firewall.py: Rules, aliases, enable/disable at DC/node/VM - network.py: Node and VM network interface operations - storage.py: Storage list, download ISO, list ISO/templates - bundles/__init__.py: Ubuntu + Proxmox default VM bundles - debug/__init__.py: Debug/ping schemas All old class names preserved as backward-compatible aliases. Old files kept in place (cleanup deferred to Task 1.8). 35 new tests in tests/test_schemas.py — all 57 tests pass.

Replace the deeply nested app/routes/v0/ directory tree (86 files) with 10 flat domain-grouped modules under app/routes/: - vms.py — VM list, lifecycle (start/stop/pause/resume), management (create/delete/clone), mass operations - vm_config.py — VM configuration (get config, cdrom, cpu, ram, set tag) - snapshots.py — Snapshot CRUD (list, create, delete, revert) - firewall.py — Firewall aliases, rules, VM/node/DC enable/disable - network.py — VM and node network interface management - storage.py — Storage list, ISO download, ISO/template listing - bundles.py — Core Ubuntu bundles + Proxmox create/start/stop/delete/snapshot bundles - runner.py — Dynamic bundle and scenario runner - debug.py — Ping and test function endpoints - ws_status.py — WebSocket VM status (unchanged) Each domain file uses shared helpers to eliminate the duplicated request_checks/reply_processing/run pattern. The __init__.py wires all routers with their original prefixes. All 80 route paths, HTTP methods, tags, and response models are preserved exactly as before — verified by the golden reference test.

Delete 120+ old route/schema/core files that are fully replaced by the new consolidated domain modules from Tasks 1.3-1.7. Update all imports in the new route files to point to app.core.runner, app.core.extractor, and the flat app.schemas.* modules instead of the old deeply nested paths. Deleted: - app/routes/v0/ (entire deeply nested route tree) - app/routes/admin_proxmox.py, admin_run.py, admin_run_bundles_core.py, admin_debug.py - app/schemas/proxmox/ (old nested schema tree) - app/schemas/bundles/core/ (old nested bundle schemas) - app/schemas/debug/ping.py (old debug schema) - app/vault/ (replaced by app/core/vault.py) - app/runner.py (replaced by app/core/runner.py) - app/extract_actions.py (replaced by app/core/extractor.py) All 59 tests pass before and after deletion.

…loyment (#51)

app/routes/debug.py

app/routes/bundles.py

app/routes/debug.py

app/schemas/firewall.py

app/schemas/network.py

app/routes/runner.py

app/routes/vms.py

app/routes/ws_status.py

t0kubetsu · 2026-03-23T10:51:56Z

This PR is not ready for merge — the following are still missing:

README documentation covering the code
Unit tests covering the code

…ic v2 fixes Merges origin/refactor (format, slim base image, pydantic v2 deprecation fixes) with local branch (unused import removals, CodeQL findings, implementation plan).

…cket helpers - test_checks_inventory.py: inventory name validation and path traversal - test_checks_playbooks.py: playbook path validation and traversal detection - test_runner_internals.py: _build_envvars, _build_cmdline, _setup_temp_dir - test_ws_helpers.py: compute_diff and load_proxmox_credentials

Mocks run_playbook_core to verify route handlers parse requests correctly, call the runner with right arguments, and return appropriate HTTP responses without needing Ansible/Proxmox.

…test structure

…idation chore: remove implementation plan docs from repo

t0kubetsu · 2026-03-24T13:33:10Z

Tests directory has to follow the structure of the fastapi app directory:

./tests
  core
  routes
  schemas
  utils

In the readme, we could add commands to display the covering of the tests.

We can also remove the 3 _*.sh scripts and the start.sh script.

Rename the requirements.yml, at the root,used by ansible to ansible_requirements.yml

We can also move inventory and playbooks to a ansible directory with the requirements.yml (like that we don't rename it but put it in a ansible directory).

Also, is pytest.ini really useful ?

We have also to take care of curl_utils scripts, are they useful ? Currently they don't take args so we have, to use it, to modify by hands the value to make them work. Is a python cli utility not better ?

pparage · 2026-03-25T07:27:01Z

@hyde-repo Regarding the curl scripts what was the intend?

hyde-repo · 2026-03-25T08:03:56Z

@pparage @t0kubetsu

Yes, please feel free to remove those files as they are temporary scripts that were not intended for long-term use.

…sion

- Pin python:3.12-slim, remove unused sshpass and start.sh copy - Move pytest/setuptools/wheel to requirements-dev.txt - Add SSH key mount to docker-compose for Ansible access

Clean up Docker production image and split dev dependencies

pparage added 18 commits March 19, 2026 09:48

fix(ws): read Proxmox credentials from inventory, not query params

183748e

WebSocket endpoint now reads API host, token ID, and token secret from the backend's own inventory/hosts.yml file. Frontend only needs to connect to ws://backend/ws/vm-status — no credentials in the browser.

test: add smoke tests and golden route reference as safety net (#53, #54

f3621a5

)

refactor: add VaultManager class replacing global state (#54)

2cc3947

refactor: add centralized config module (#53, #54)

ff85436

refactor: add clean runner and extractor in app/core/ (#53, #54)

c60aa88

refactor: extract exception handlers to app/core/exceptions (#54)

346b543

fix: replace broken venv.logger import with proper logging (#54)

0d5725b

refactor: rewrite main.py with application factory pattern (#54)

dd62295

refactor: make start.sh portable with .env support (#54)

0dd358c

refactor: replace print statements with structured logging (#54)

0b1622a

feat(docker): add Dockerfile and docker-compose for containerized dep…

6fc23df

…loyment (#51)

docs: comprehensive README with setup, architecture, and API guide (#52)

1142d75

docs: add Sphinx-style docstrings to all modules (#52)

700af4e

github-code-quality bot found potential problems Mar 23, 2026

View reviewed changes

format

119c2f6

github-code-quality bot found potential problems Mar 23, 2026

View reviewed changes

app/routes/ws_status.py Fixed Show fixed Hide fixed

t0kubetsu added 2 commits March 23, 2026 11:35

switch to slim from 3.12

2d99e7a

fix: resolve pydantic v2 deprecation warnings in vm schemas

a086980

pparage added 6 commits March 23, 2026 16:32

docs: add implementation plan for PR #62 README and test coverage

685109a

fix: resolve CodeQL findings — unused imports, import *, empty except

9dd8e42

fix: remove unused List import from bundles and storage schemas

94387d8

merge: reconcile local CodeQL fixes with remote formatting and pydant…

fed43dc

…ic v2 fixes Merges origin/refactor (format, slim base image, pydantic v2 deprecation fixes) with local branch (unused import removals, CodeQL findings, implementation plan).

test: add integration tests for debug and VM route handlers

f7d7a11

Mocks run_playbook_core to verify route handlers parse requests correctly, call the runner with right arguments, and return appropriate HTTP responses without needing Ansible/Proxmox.

pparage added 3 commits March 24, 2026 11:22

test: add response schema validation tests

be954f6

docs: expand README with WebSocket API, Docker details, logging, and …

fb8e3c8

…test structure

test: add unit tests for text_cleaner, vm_id_resolver, and bundle val…

0cb0e9b

…idation chore: remove implementation plan docs from repo

format

f927c18

pparage and others added 4 commits March 25, 2026 09:07

test(tags): add unit tests for vm_set_tag route and tag format conver…

da91fa7

…sion

test(realtime): add WebSocket tag tests and list_usage field coverage

124b88d

refactor(docker): clean up production image and split dev dependencies

b9d3d8f

- Pin python:3.12-slim, remove unused sshpass and start.sh copy - Move pytest/setuptools/wheel to requirements-dev.txt - Add SSH key mount to docker-compose for Ansible access

Merge pull request #63 from range42/feature/deployer-enhancements

f927491

Clean up Docker production image and split dev dependencies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor#62

Refactor#62
t0kubetsu wants to merge 35 commits intomainfrom
refactor

t0kubetsu commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t0kubetsu commented Mar 23, 2026 •

edited by pparage

Loading

Uh oh!

t0kubetsu commented Mar 24, 2026 •

edited

Loading

Uh oh!

pparage commented Mar 25, 2026

Uh oh!

hyde-repo commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

t0kubetsu commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t0kubetsu commented Mar 23, 2026 • edited by pparage Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t0kubetsu commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pparage commented Mar 25, 2026

Uh oh!

hyde-repo commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

t0kubetsu commented Mar 23, 2026 •

edited by pparage

Loading

t0kubetsu commented Mar 24, 2026 •

edited

Loading