Conversation
| ### Install pgadmin (optional) | ||
|
|
||
| Change the default settings. | ||
|
|
||
| ``` | ||
| podman run --name pgadmin -p 5050:80 -e "PGADMIN_DEFAULT_EMAIL=pgadmin4@pgadmin.org" -e "PGADMIN_DEFAULT_PASSWORD=admin" -d dpage/pgadmin4 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I don't think that this is necessary here
There was a problem hiding this comment.
It is optional. At least, people will know it is an option they can use and explore. It is a simple podman command to get started. Ideally, you would have a Dockerfile with a docker-compose file in this project. The setup and configuration time would have been saved for anyone who wants to contribute to this project.
For your information, Podman 2.0 was released less than one month ago.
|
|
||
| EMPTY_FIELD_MSG = 'This field cannot be blank' | ||
|
|
||
| class ReplyResource(Resource): |
There was a problem hiding this comment.
It might be confusing to have 2 ReplyResource in the code base. I suggest consolidating the two resources and replacing the post method below with patch
There was a problem hiding this comment.
It'll also ensure that we won't have two copies of replies_fields
There was a problem hiding this comment.
I agree with you. I would suggest the owner of the code to clean and remove unused code because it can be confusing. For example, MongoDB seems to be replaced with PostgreSQL. Also, new_backend, main, app, src in the same project makes it a little bit confusing. I think one common convention is app/main.py.
There was a problem hiding this comment.
You're absolutely right (and I apologize about that), the code is still patchy but we're working on fixing that.
Would you like to update your code and we'll take care of re-organizing the rest?
2 participants
• Feature to edit a reply (reply blueprint)
• Update README.md
• Remove duplicated configuration in .env_example