Here's fixes for a couple of small bugs I found.#17
Open
sherbang wants to merge 3 commits intoranjez:masterfrom
Open
Here's fixes for a couple of small bugs I found.#17sherbang wants to merge 3 commits intoranjez:masterfrom
sherbang wants to merge 3 commits intoranjez:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current release, when installed without a previous version (load unpacked) doesn't work. errors in _background.html when localStorage['rules'] is undefined, and the UI doesn't work when there's more than 1 rule. I put these bugfixes together for my own use, but hopefully they're helpful to you as well.