feat(acp-client): toolbar row with settings, plan, and always-visible cancel#169
Merged
feat(acp-client): toolbar row with settings, plan, and always-visible cancel#169
Conversation
Refactor the chat input area to place the settings button, plan button, and cancel button in a unified toolbar row above the text input. The cancel button is now always visible so users can force-cancel even when ACP status reporting is unreliable (e.g., with subagents). - Move settings gear from form row into toolbar with pill styling - Move cancel from conditional form button to always-visible toolbar item - Cancel is red when prompting, muted gray otherwise, always clickable - Remove mb-2 from StickyPlanButton (parent toolbar handles spacing) - Add 6 tests for toolbar layout, cancel behavior, and styling states Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm lintpnpm typecheck(viapnpm build)pnpm test— 233 tests pass (6 new)UI Compliance Checklist (Required for UI changes)
Exceptions (If any)
N/A
Agent Preflight (Required)
Classification
External References
N/A: Frontend-only layout refactor within acp-client package.
Codebase Impact Analysis
packages/acp-client/src/components/AgentPanel.tsx— toolbar layout refactorpackages/acp-client/src/components/StickyPlanButton.tsx— remove margin classpackages/acp-client/src/components/AgentPanel.test.tsx— 6 new testsDocumentation & Specs
N/A: No API or behavioral changes requiring doc updates.
Constitution & Risk Check