fix(acp-client): fix scroll-to-bottom FAB visibility#172
Merged
Conversation
The FAB was rendering behind the scroll container because overflow-y:auto creates a new stacking context. Added z-10 to ensure the button paints above the scrollable area. Also bumped right offset from right-3 to right-5 to clear the scrollbar. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z-10to the scroll-to-bottom FAB so it renders above the scroll container (which creates a stacking context viaoverflow-y: auto)right-3(12px) toright-5(20px) to clear the scrollbarValidation
pnpm typecheck(via build)pnpm test— 246 tests passpnpm lint(implicit — no new code, only class changes)Exceptions (If any)
Agent Preflight (Required)
Classification
External References
N/A: CSS z-index fix, no external APIs.
Codebase Impact Analysis
packages/acp-client/src/components/AgentPanel.tsx— Addedz-10and changedright-3toright-5on FAB button classnameDocumentation & Specs
N/A: Bug fix to CSS classes only.
Constitution & Risk Check
N/A: No business logic changes.
Generated with Claude Code