This repository was archived by the owner on May 18, 2021. It is now read-only.
Changed class variables to instance variables in plugins#3
Open
kn0 wants to merge 1 commit intorapid7:masterfrom
Open
Changed class variables to instance variables in plugins#3kn0 wants to merge 1 commit intorapid7:masterfrom
kn0 wants to merge 1 commit intorapid7:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the class 'hierarchy' variables
@@descriptionand@@confidenceto instance variables within each plugin (and supporting code). Before this change, each time a plugin was required by plugins.rb, the variables were found in the class hierarchy (which looked up to the PluginTemplate class). The value of the variables were then overwritten. This caused the list of plugins to only show the description of the last plugin required (and set the confidence of each plugin to show as 0.10).