-
Notifications
You must be signed in to change notification settings - Fork 3
Remove disabled colors for disabled state #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e-components into feature/add-disabled-colors
|
Do we need those disabled examples? |
Well it isn't mandatory to show but it can be nice to see how the disabled state looks like. I can remove it more people think that it is not necessary to show the disabled state example. @Jade-GG @jordythevulder |
|
So now we're requiring people to always add these classes when they want a disabled state? How do we make sure they know which classes to add to make sure all the buttons are consistent in their disabled state? This will just require a bunch of repetition. Should we add a prop that adds these classes instead? something like: instead of: This would be a lot cleaner IMO, it fixes both of the issues I have with this (inconsistency, repetition). |
|
Maybe a input variant? Something like input.disabled? |
That's also something I was thinking, though maybe more like |
…e-components into feature/add-disabled-colors
|
I have checked this with @jordythevulder. We have decided that the input component won't have a visual disabled state. The input is disabled and will have a |
Remove the disabled colors from the input components when it have a disabled state. This can be manually added when you need to style an disabled input.