Skip to content

split testing libraries from run libraries in dependencies.yaml #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayavenkatesh19 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

split testing libraries from run libraries in dependencies.yaml #5447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ad392
add run_notebooks key
jayavenkatesh19 Mar 24, 2026
95876ce
Empty commit to retrigger CI
jayavenkatesh19 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@ files:
- depends_on_libcugraph
- depends_on_libcugraph_etl
- depends_on_libcugraph_tests
run_notebooks:
output: none
includes:
- cuda_version
- py_version
- run_notebooks
- depends_on_cugraph
Copy link
Copy Markdown
Member

@jameslamb jameslamb Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- depends_on_cugraph
- depends_on_cudf
- depends_on_cugraph

There are some direct imports of cudf in these notebooks. I think cudf should be added to this list.

- depends_on_pylibcugraph
- depends_on_libcugraph
test_notebooks:
output: none
includes:
Expand Down Expand Up @@ -483,8 +492,8 @@ dependencies:
- output_types: [conda, requirements]
packages:
- certifi
- ipython
- notebook>=0.5.0
- &ipython ipython
- &notebook notebook>=0.5.0
test_python_common:
common:
- output_types: [conda, pyproject, requirements]
Expand All @@ -494,17 +503,28 @@ dependencies:
- pytest-benchmark
- pytest-cov
- pytest-xdist
- scipy
- &scipy scipy
test_python_cugraph:
common:
- output_types: [conda, pyproject, requirements]
packages:
- certifi
- networkx>=2.5.1
- &networkx networkx>=2.5.1
- *numpy
- packaging
- python-louvain
- scikit-learn>=0.23.1
# Runtime dependencies for included cugraph notebooks, used in the
# rapidsai/notebooks Docker image. Only lists packages not already
# provided by cugraph, pylibcugraph, or libcugraph.
Comment on lines +517 to +519
Copy link
Copy Markdown
Member

@jameslamb jameslamb Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Runtime dependencies for included cugraph notebooks, used in the
# rapidsai/notebooks Docker image. Only lists packages not already
# provided by cugraph, pylibcugraph, or libcugraph.
# Runtime dependencies for cuGraph notebooks tested in CI.
# Also used in the rapidsai/notebooks Docker image.
# Only lists packages that are directly imported in notebooks.

I might not have been clear in my previous comments, sorry. This should be anything that's directly imported in the notebooks and isn't part of the standard library.

run_notebooks:
common:
- output_types: [conda]
packages:
- *ipython
- *networkx
- *notebook
- *scipy
Copy link
Copy Markdown
Member

@jameslamb jameslamb Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This is exactly what I was envisioning.

Looking at the output of this:

git grep 'import' notebooks/

And the subset of notebooks actually tested in rapidsai/docker CI:

cugraph/algorithms/centrality/Betweenness.ipynb
cugraph/algorithms/centrality/Centrality.ipynb
cugraph/algorithms/centrality/Degree.ipynb
cugraph/algorithms/centrality/Eigenvector.ipynb
cugraph/algorithms/centrality/Katz.ipynb
cugraph/algorithms/community/Community-Clustering.ipynb
cugraph/algorithms/community/ECG.ipynb
cugraph/algorithms/community/Induced-Subgraph.ipynb
cugraph/algorithms/community/Louvain.ipynb
cugraph/algorithms/community/Spectral-Clustering.ipynb
cugraph/algorithms/community/Triangle-Counting.ipynb
cugraph/algorithms/community/ktruss.ipynb
cugraph/algorithms/components/ConnectedComponents.ipynb
cugraph/algorithms/cores/core-number.ipynb
cugraph/algorithms/cores/kcore.ipynb
cugraph/algorithms/link_analysis/HITS.ipynb
cugraph/algorithms/link_analysis/Pagerank.ipynb
cugraph/algorithms/link_prediction/Jaccard-Similarity.ipynb
cugraph/algorithms/link_prediction/Overlap-Similarity.ipynb
cugraph/algorithms/link_prediction/Sorensen_coefficient.ipynb
cugraph/algorithms/link_prediction/similarity_combined.ipynb
cugraph/algorithms/sampling/RandomWalk.ipynb
cugraph/algorithms/structure/Renumber-2.ipynb
cugraph/algorithms/structure/Renumber.ipynb
cugraph/algorithms/structure/Symmetrize.ipynb
cugraph/algorithms/traversal/BFS.ipynb
cugraph/algorithms/traversal/SSSP.ipynb

(build link)

I think we need a few more entries here:

Note that notebooks/algorithms/layout/Force-Atlas2.ipynb, which requires some plotting libraries like cuxfilter and holoviews, is not tested there and so its dependencies can be skipped.

test_python_pylibcugraph:
common:
- output_types: [conda, pyproject, requirements]
Expand Down
Loading