Replace legacy SCC with the new SCC implementation and SCC performance improvements#5469
Open
seunghwak wants to merge 20 commits intorapidsai:mainfrom
Open
Replace legacy SCC with the new SCC implementation and SCC performance improvements#5469seunghwak wants to merge 20 commits intorapidsai:mainfrom
seunghwak wants to merge 20 commits intorapidsai:mainfrom
Conversation
seunghwak
added
improvement
seunghwak
changed the title
seunghwak
added
breaking
Collaborator
|
/ok to test 2bd8c9b |
Contributor
Author
|
/ok to test 5959301 |
ChuckHastings
approved these changes
Mar 31, 2026
jnke2016
approved these changes
Mar 31, 2026
Contributor
Author
|
/ok to test ccc3fdc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace legacy SCC with the new SCC implementation.
In addition, this code adds chain removal logic (a chain of in-degree 1 out-degree 1 vertices) in peeling out trivial singleton SCC vertices. The chain removal is based on pointer jumping and significantly reduces the number of iterations in recursively removing 0 in-degree or 0 out-degree vertices.
Breaking as the legacy SCC is removed.