Resolve forward-merge release/26.04 into main#5480
Closed
AyodeAwe wants to merge 2 commits intorapidsai:mainfrom
Closed
Resolve forward-merge release/26.04 into main#5480AyodeAwe wants to merge 2 commits intorapidsai:mainfrom
AyodeAwe wants to merge 2 commits intorapidsai:mainfrom
Conversation
This PR adds the disjoint sampling feature to sampling in C++. C++ tests exist for homogeneous uniform and biased sampling, both for SG and MG. This should get us started on the disjoint feature, we can add tests for heterogeneous and temporal variations as well, I plan to do that in a follow on activity. We also need to test that the C API level, which I will add to a later pull request. Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: rapidsai#5414
Collaborator
|
Isn't this the same as #5478? |
Collaborator
|
Everything's failing on main in CI until #5479 gets merged. |
Contributor
Author
That's right @ChuckHastings. I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve merge conflicts in the bot's forward merger PR: #5476