Fix malformed versions from push-triggered builds on release branches#250
Merged
AyodeAwe merged 2 commits intorapidsai:mainfrom Mar 17, 2026
Merged
Conversation
jameslamb
reviewed
Mar 16, 2026
Member
jameslamb
left a comment
There was a problem hiding this comment.
Thanks so much for investigating this! The description and comments helped me a lot.
I think applying a fix here is a good approach. I'm unsure if we need that one more nightly package pushed to the nightly indices, but it's not too expensive to have it (since CPU CI runners are relatively cheap and plentiful).
But I left one suggestion for a slightly different version for those.
Contributor
Author
|
Thanks @jameslamb! Addressed! |
jameslamb
approved these changes
Mar 17, 2026
Member
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for considering it, let's merge this ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rapids-generate-versionto handle the case where the nearest git tag has no stage (e.g.,v25.10.00instead ofv25.10.00a){stage}is empty, dunamai's{base}{stage}{distance}format produces garbage like25.10.000or26.02.010aas the separatorContext
During the cucim v26.02.01 hotfix (ref: ops#4293), the push to
release/26.02triggered a build that produced packages with malformed versions (libcucim-26.02.010). The tag-triggered build produced the correct version (26.02.01).This happens because push-triggered builds use
{base}{stage}{distance}but when the nearest tag is a release/hotfix tag,{stage}is empty -- so distance concatenates directly onto base.Verification
Tested locally against cucim (the repo where the bug was originally reported) and rmm:
cucim:
v26.02.0126.02.01026.02.01a0v26.02.0026.02.00026.02.00a0v26.04.00a+1826.04.00a1826.04.00a18rmm:
v26.02.0026.02.00026.02.00a0v25.12.0025.12.00025.12.00a0v26.04.00a+5226.04.00a5226.04.00a52How to reproduce