Skip to content

wheels-build: do not fail fast#517

Merged
rapids-bot[bot] merged 1 commit intomainfrom
wheels-no-fail-fast
Mar 30, 2026
Merged

wheels-build: do not fail fast#517
rapids-bot[bot] merged 1 commit intomainfrom
wheels-no-fail-fast

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Mar 30, 2026

Proposes allowing all wheels-build jobs to run to completion, instead of immediately cancelling all of them when 1 fails.

This should help with narrowing down issues, like "only fails on arm64".

Motivation

Noticed while working on rapidsai/cugraph#5479, where @ChuckHastings and I were investigating an issue that only occurred on CUDA 12 builds. Noticed that all conda-cpp-build jobs ran to completion, but wheels-build jobs were cancelled after the first failure.

image

Notes for Reviewers

This change will increase CI runner usage, but I think it's worth it:

  • CPU-only runners used for builds are generally cheap and plentiful
  • failed wheel build jobs are valuable:
    • they provide information to speed up debugging (e.g. "only fails on arm64")
    • they partially fill up the shared build caches and package caches, which other CI jobs benefit from and which might reduce the time-to-resolution for issues

@jameslamb jameslamb requested a review from a team as a code owner March 30, 2026 21:59
@jameslamb jameslamb requested review from bdice and removed request for a team March 30, 2026 21:59
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 30, 2026
@jameslamb
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 9b3ec6b into main Mar 30, 2026
2 checks passed
@jameslamb jameslamb deleted the wheels-no-fail-fast branch March 30, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants