Skip to content

Feat: add enable/disable wrappers methods#498

Open
ShiraiEd wants to merge 6 commits intomainfrom
refactor/explicit-enable-disable-methods
Open

Feat: add enable/disable wrappers methods#498
ShiraiEd wants to merge 6 commits intomainfrom
refactor/explicit-enable-disable-methods

Conversation

@ShiraiEd
Copy link
Copy Markdown
Collaborator

@ShiraiEd ShiraiEd commented Apr 15, 2026

Summary

Adds new enable/disable Rapina app methods that wraps around the .with_* methods

Related Issues

Closes #476

Checklist

  • cargo fmt passes
  • cargo clippy has no warnings
  • Tests pass
  • Documentation updated (if needed)

@ShiraiEd ShiraiEd requested a review from arferreira as a code owner April 15, 2026 02:59
@github-actions github-actions bot added the area: core Core framework label Apr 15, 2026
@ShiraiEd ShiraiEd requested review from lucaserm and removed request for lucaserm April 15, 2026 03:00
@ShiraiEd ShiraiEd marked this pull request as draft April 15, 2026 03:00
@ShiraiEd ShiraiEd added the status: needs triage Needs review label Apr 15, 2026
@github-actions github-actions bot added the area: docs Documentation site label Apr 16, 2026
@ShiraiEd ShiraiEd marked this pull request as ready for review April 16, 2026 00:38
@ShiraiEd
Copy link
Copy Markdown
Collaborator Author

Is the way that this is displayed in the docs good?

@ShiraiEd ShiraiEd changed the title refactor: add enable/disable methods, deprecate with_*(bool) pattern Feat: add enable/disable wrappers methods Apr 16, 2026
@ShiraiEd ShiraiEd removed the status: needs triage Needs review label Apr 16, 2026
Comment thread rapina/src/app.rs
Comment thread rapina/src/app.rs
@ShiraiEd ShiraiEd force-pushed the refactor/explicit-enable-disable-methods branch from ee8bec8 to dd87049 Compare April 17, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core framework area: docs Documentation site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion]: Replace with_<feature>(bool) pattern with explicit enable_<feature>() and disable_<feature>() methods

2 participants