Fix inverted offline mode logic preventing online connection #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The app was incorrectly entering offline mode even when server connections succeeded. Users would see the offline mode UI despite having working network connectivity to their server.
Root Cause
In
TabRouterViewModel.swift, theloadLibraries()function had inverted boolean logic:The issue:
reduce(true) { $0 && $1 }returnstrueonly when ALL connections succeedallConnectionsUnavailableand triggered offline mode whentrueSolution
Changes:
anyConnectionSucceededfor clarity||) with initial valuefalseTest Plan
🤖 Generated with Claude Code