Add user preference to disable haptic feedback #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a toggle in Settings to allow users to disable haptic feedback throughout the app. Previously, haptic feedback was always enabled with no way to turn it off. Changes: - Add 'enableHaptics' preference key (defaults to true) - Create View+SensoryFeedback.swift with conditional hapticFeedback() modifier that wraps SwiftUI's sensoryFeedback() and respects the user preference - Add HapticsPreference.swift toggle component for the settings UI - Add toggle to PreferencesView in the appearance section - Replace all 28 occurrences of .sensoryFeedback() with .hapticFeedback() across 21 view files - Add localized strings for "Haptic feedback" in all supported languages: EN, FR, DE, RU, SV, UK, ZH-Hans When disabled, the hapticFeedback() modifier simply returns the content unchanged, preventing any vibration feedback. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need
Some users prefer not to have haptic feedback (vibrations) when using the app, either due to personal preference or accessibility reasons. Currently, there is no way to disable haptic feedback in the app settings.
Solution
Added a new preference toggle that allows users to enable/disable haptic feedback throughout the app.
Implementation Details
New preference key in
Keys+Entries.swift:New View extension (
View+SensoryFeedback.swift):hapticFeedback(_:trigger:)modifier that wraps SwiftUI'ssensoryFeedbackConditionalSensoryFeedbackModifierthat checks the preference before applying feedbackNew preference toggle (
HapticsPreference.swift):Migration of existing code:
.sensoryFeedback()with.hapticFeedback()across 21 filesLocalization:
Files Changed
ShelfPlayerKit/Extensions/Keys+Entries.swift- New preference keyMultiplatform/Extensions/SwiftUI/View+SensoryFeedback.swift- New (conditional modifier)Multiplatform/Preferences/HapticsPreference.swift- New (toggle component)Multiplatform/Preferences/PreferencesView.swift- Added toggle to UIMultiplatform/Localizable.xcstrings- Translations.sensoryFeedback()with.hapticFeedback()Test Plan
🤖 Generated with Claude Code