Sleep timer improvements: configurable auto-extend window and reset on play #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the "play extends sleep timer" feature used a hardcoded 10-second window. This change adds a user-configurable setting to control how long after the sleep timer expires the user can press play to automatically restart it. Changes: - Add extendSleepTimerOnPlayWindow preference key (default: 10 seconds) - Update AudioPlayer to use the configurable value instead of hardcoded 10 - Add UI controls in SleepTimerEditor: toggle for the feature and stepper for the time window (5-60 seconds in 5-second increments) - Add localized strings for all supported languages (EN, FR, DE, RU, SV, UK, ZH-Hans) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a new setting that resets the sleep timer to its original duration when the user pauses and resumes playback before the timer expires. This is useful for users who want the timer to restart every time they resume listening. Example: If you set a 10-minute timer and pause after 5 minutes, when you resume the timer will restart at 10 minutes instead of continuing from 5 minutes remaining. Changes: - Add reset computed property to SleepTimerConfiguration that creates a new timer with the same original duration starting from now - Add resetSleepTimerOnPlay preference key (default: false) - Update AudioPlayer.play() to reset active timer when preference is enabled - Add toggle in SleepTimerEditor with descriptive footer - Add localized strings for all supported languages Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code