-
Notifications
You must be signed in to change notification settings - Fork 67
Add example splash screen support #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tdewey-rpi
commented
Oct 10, 2025
- Introduced a new directory for splash screen examples, including a configuration file and documentation.
- Added a YAML configuration file for splash screen settings, allowing customization of the splash image and boot parameters.
- Created documentation detailing the features, usage, and technical requirements of the splash screen layer.
- Included an example script for generating a simple splash screen image using ImageMagick.
- Introduced a new directory for splash screen examples, including a configuration file and documentation. - Added a YAML configuration file for splash screen settings, allowing customization of the splash image and boot parameters. - Created comprehensive documentation detailing the features, usage, and technical requirements of the splash screen layer. - Included an example script for generating a simple splash screen image using ImageMagick.
- Expanded the splash-demo.yaml file with comprehensive comments and instructions for creating and using a custom boot splash screen on Raspberry Pi OS. - Included steps for building the image and generating the splash screen image, enhancing usability for developers.
echo "Configuring splash screen from $SPLASH_IMAGE" >&2 | ||
# Build command arguments | ||
if igconf isy splash_skip_image_checks && ! igconf isy splash_update_cmdline ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to use igconf here to test variables, but it's more defensive to use set -u and reference the variable directly (eg testing $IGconf_splash_skip_image_checks
). For example, if the X-Env-Var declaration was changed or there was a typo, it would be easy to miss in the scripting logic with igconf, whereas it would result in a hard failure if the variable was referenced by name. Using X-Env-Var-*-Set = y
will always ensure the variable has a value.
@@ -0,0 +1,81 @@ | |||
# METABEGIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The splash layer and associated assets would be more applicable under layer/rpi/device/
, as splash is a device specific feature. I could imagine Connect and OTA etc residing under layer/rpi/device/services/
.
Just trying to keep compartmentalisation of layers in mind as we add them.
# X-Env-Layer-Name: rpi-splash-screen | ||
# X-Env-Layer-Desc: Raspberry Pi fullscreen splash screen support with custom image configuration. | ||
# X-Env-Layer-Version: 1.0.0 | ||
# X-Env-Layer-Requires: rpi-essential-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need rpi-essential-base?