Skip to content

Conversation

@kshanmol
Copy link
Contributor

@kshanmol kshanmol commented Nov 27, 2025

Description

For easier correlation across panels, we use a shared cross hair for all Grafana dashboards. This somehow was missed in the Serve dashboard - fixing this inconsistency.

Related issues

None

Additional information

Current behaviour:
image

@kshanmol kshanmol requested a review from a team as a code owner November 27, 2025 18:00
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Serve Grafana dashboard to enable the shared crosshair feature, which improves usability by allowing easier correlation of data points across different panels. The change correctly sets graphTooltip to 1 in serve_grafana_dashboard_base.json, aligning the Serve dashboard's behavior with other Grafana dashboards in the project. This is a good consistency improvement. While this PR targets the main Serve dashboard, it might be worth checking if other Serve-related dashboards (e.g., for deployments and LLMs) should also have the shared crosshair enabled to provide a consistent user experience across all Serve monitoring views.

@kshanmol kshanmol requested a review from alanwguo November 27, 2025 18:03
@kshanmol kshanmol changed the title Default shared cross hair for Serve Grafana dashboard Use shared cross hair graph tooltip in Serve Grafana dashboard Nov 27, 2025
Signed-off-by: anmol <anmol@anyscale.com>
@kshanmol kshanmol force-pushed the default-crosshair-serve-dashboard branch from ef907e3 to 4ae45e4 Compare November 27, 2025 18:12
@kshanmol kshanmol added the go add ONLY when ready to merge, run all tests label Nov 27, 2025
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling labels Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants