Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 27 27
Lines 1072 1072
=======================================
Hits 980 980
Misses 92 92 |
There was a problem hiding this comment.
Can we rename the folder to e2e ?
There was a problem hiding this comment.
i have renamed the folder to e2e
| class RazorpayTest extends Razorpay { | ||
| constructor(options) { | ||
| super(options) | ||
| this.api.rq = request.defaults({ |
There was a problem hiding this comment.
Can we pass hostUrl as options in constructor of Razorpay itself ?
By default, it would be api.razorpay.com else it can be https://api-web.dev.razorpay.in
There was a problem hiding this comment.
added hostUrl in options
There was a problem hiding this comment.
I didn't mean adding it in RazorpayTest but in Razorpay class. In that case, we don't need RazorpayTest itself. We can directly use Razorpay by passing hostUrl.
Sorry for this confusion.
There was a problem hiding this comment.
Just realised that adding it in class Razorpay would have other problems since that is a public API. Let's keep this as such for now.
e2e/razorpay.js
Outdated
| const Razorpay = require("../dist/razorpay"); | ||
| let request = require('request-promise'); | ||
|
|
||
| class RazorpayTest extends Razorpay { |
There was a problem hiding this comment.
Let's rename this Class to RazorpayBeta
This reverts commit 282d7ef.
| 'use strict'; | ||
|
|
||
| const Razorpay = require("../dist/razorpay"); | ||
| let request = require('request-promise'); |
4 participants
Created Test Razorpay instance for test url