More-context-to-measurement-out-of-bounds #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacharanero
approved these changes
May 18, 2025
Member
pacharanero
left a comment
pacharanero
left a comment
There was a problem hiding this comment.
Looks good to me.
(At some future point we might want to think about moving all the text in API responses into a single file in an i8n folder so that we can ready the system for responses in other languages eg Welsh being likely necessary soon for Redbook. I'll check whether we have an issue for this already)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Consumers of the digital growth charts API are finding that +/- 8 SDS errors are not intuitive and requested that the age of the child be included in the error response.
changes in this PR are to include the age of the child in the error message