Add JUnit tests for validating PDB ID regex#6
Merged
Conversation
josemduarte
requested changes
Feb 17, 2026
Member
josemduarte
left a comment
There was a problem hiding this comment.
Thank you for adding tests! See one comment about junit version
pom.xml
Outdated
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.2</version> |
Member
There was a problem hiding this comment.
Since this is the first time we add tests for this project, I think it'd be best to have the newest junit version (now version 6). Transforming the test to the latest version should be quite easy, I think even IntelliJ has a tool to migrate. Otherwise with AI.
src/test/java/org/rcsb/common/constants/IdentifierRegexTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/rcsb/common/constants/IdentifierRegexTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@josemduarte I upgraded JUnit to the latest version and adapted unit tests. Thanks! |
Contributor
Author
|
Thanks @josemduarte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds JUnit tests for validating PDB ID regex behavior.