Skip to content

Secrets for explicit env vars#19

Merged
josemduarte merged 13 commits intomasterfrom
dev-jd-secrets
May 16, 2025
Merged

Secrets for explicit env vars#19
josemduarte merged 13 commits intomasterfrom
dev-jd-secrets

Conversation

@josemduarte
Copy link
Member

  • App init changed to get user/pwd from explicit env vars
  • Helm charts adapted accordingly
  • General cleanup of Helm charts to align with style elsewhere

@josemduarte
Copy link
Member Author

@jeremy-rcsb @valasatava could you have a look?

Copy link
Contributor

@valasatava valasatava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@jeremy-rcsb jeremy-rcsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

…depends on the other 2 so that there's no race condition
Comment on lines +16 to +19
name: "Run automated workflow"
uses: rcsb/devops-cicd-github-actions/.github/workflows/workflow-java.yaml@master
with:
mainline_branch: master

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 10 months ago

To fix the issue, we will add a permissions block to the workflow. Since the workflow appears to be a CI/CD pipeline, it is likely that it only needs read access to the repository contents. We will set contents: read at the root level of the workflow to apply minimal permissions to all jobs. If additional permissions are required for specific jobs, they can be added later.


Suggested changeset 1
.github/workflows/workflow-java.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/workflow-java.yml b/.github/workflows/workflow-java.yml
--- a/.github/workflows/workflow-java.yml
+++ b/.github/workflows/workflow-java.yml
@@ -2,2 +2,5 @@
 
+permissions:
+  contents: read
+
 on:
EOF
@@ -2,2 +2,5 @@

permissions:
contents: read

on:
Copilot is powered by AI and may make mistakes. Always verify output.
@josemduarte josemduarte merged commit 3082801 into master May 16, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants