Merged
Conversation
Member
josemduarte
commented
May 16, 2025
- App init changed to get user/pwd from explicit env vars
- Helm charts adapted accordingly
- General cleanup of Helm charts to align with style elsewhere
…re. Defining secrets as per style elsewhere, no changes to what secrets are read yet
Member
Author
|
@jeremy-rcsb @valasatava could you have a look? |
…depends on the other 2 so that there's no race condition
Comment on lines
+16
to
+19
| name: "Run automated workflow" | ||
| uses: rcsb/devops-cicd-github-actions/.github/workflows/workflow-java.yaml@master | ||
| with: | ||
| mainline_branch: master |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 months ago
To fix the issue, we will add a permissions block to the workflow. Since the workflow appears to be a CI/CD pipeline, it is likely that it only needs read access to the repository contents. We will set contents: read at the root level of the workflow to apply minimal permissions to all jobs. If additional permissions are required for specific jobs, they can be added later.
Suggested changeset
1
.github/workflows/workflow-java.yml
| @@ -2,2 +2,5 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.