Open
Conversation
Collaborator
|
It seems like this is the code we should be trying to use: https://github.com/rdaly525/coreir/pull/1013/files#diff-1d13ccebd6fd308ba92fd6d7889462cc6b4a370afdbc5edb561dfe2ddab84781R1147-R1154 but because they metadata is lost when you save to JSON it's not working. Let me investigate the options there, perhaps we should save that metadata to be persistent across invocations. However, it's likely that you should also just be able to save the verilog file directly from the runtime which would avoid that issue. |
Owner
|
@joyliu37 if you use serializeToFile(...) instead of saveToFile(...) All the metadata and dependencies will get saved in the one verilog file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes to the verilog analysis passes and it work for me for the issue.
#941