Open
Conversation
joyliu37
reviewed
Jul 22, 2021
Collaborator
joyliu37
left a comment
joyliu37
left a comment
There was a problem hiding this comment.
Looks good to me. So I need to use serializeToFile to dump the generator information?
joyliu37
approved these changes
Jul 22, 2021
joyliu37
requested changes
Jul 22, 2021
| ->getMetaData()["verilog"]; | ||
| module_name = make_name(instance_module->getName(), verilog_json); | ||
| } | ||
| if (instance_module->isGenerated() && instance_module->getGenerator()->getMetaData().count("verilog") > 0) { |
Collaborator
There was a problem hiding this comment.
After testing with clockwork, I need to change this line of code into
if (instance_module->isGenerated() && instance_module->getMetaData().count("verilog") > 0)
Collaborator
There was a problem hiding this comment.
@rdaly525 I think this means you need to check two separate cases here:
- the instance_module has
"verilog"metadata - the instance_module->getGenerator() has
"verilog"metadata
leonardt
approved these changes
Jul 27, 2021
Collaborator
leonardt
left a comment
leonardt
left a comment
There was a problem hiding this comment.
Change looks fine, but I think there's one extra case needed for Joey's use case
| ->getMetaData()["verilog"]; | ||
| module_name = make_name(instance_module->getName(), verilog_json); | ||
| } | ||
| if (instance_module->isGenerated() && instance_module->getGenerator()->getMetaData().count("verilog") > 0) { |
Collaborator
There was a problem hiding this comment.
@rdaly525 I think this means you need to check two separate cases here:
- the instance_module has
"verilog"metadata - the instance_module->getGenerator() has
"verilog"metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #941