Add initialization logic to accumulation register#790
Open
norabarlow wants to merge 2 commits intoubufferfrom
Open
Add initialization logic to accumulation register#790norabarlow wants to merge 2 commits intoubufferfrom
norabarlow wants to merge 2 commits intoubufferfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous accumulation register logic works great, except for the first time the register is used. The register value isn't initialized to anything, which messes things up.
To fix this, I
Note: this still outputs valid on the last iteration. We could change it to output and initialize on iteration 0 (would save a PE by removing a selector), but we would need a register to hold the in_valid signal of the previous sequence as we move to a new computation sequence. I chose not to do this for now but it can be changed later.