PowerController (PowerManager Client) library implementation #289
Conversation
|
|
|
Hi skamath: Copyright 2025 RDK Management Thank you, |
updated NOTICE as per this comment - rdkcentral#289 (comment)
santoshcomcast
left a comment
santoshcomcast
left a comment
There was a problem hiding this comment.
Can you please review and resolve the comment?
…l state tracking - PowerManager Init & Term, avoids crash if API(s) are called after `Dispose` (older API now removed) - Introduced isOperational and it's state change callback
|
Looks quite good from an overall point of view (did not dive into the implementation code_ liked the setup.It is a C interface exposed without leaking Thunder details. So the setup is good. One minor remark, so no need to change it (but would prefer it ;-) ), Why i a called a PowerManager? I do not know about your manager, but my Manager does nothing and can do nothing, he just tells me what to do. he delegates.The real execution work is done by me. I Control what needs to be done :-) Hence why all Metrlogical Thunder code does not contain 1 Manager, it has Controllers. Naming of object should correctly describe what the object represent. It is my personal believe that Controller is a better naming, as the object really controls the power, than Manager. |
update copyright in cmake file dsmgr testing complete interface changes for enhanced instance management and add operational state tracking - PowerManager Init & Term, avoids crash if API(s) are called after `Dispose` (older API now removed) - Introduced isOperational and it's state change callback
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
skamath
changed the title
6 participants
No description provided.