L1tests ocdm #290

NRofina · 2025-01-23T18:46:23Z

Please review the change for RDK-53574 OCDM client l1test framework

* [OCDM] Extension for the new functionalities. * Forgot to add the capabilities. Added * [CAPSPARSER] Add a GstCapsParser for getting stream data. * [OCDM] Add a caps parse contributed by Comcast. * Add version 2 of decrypt. * Change GST_BUFFER to GST_ARRAY * Revert previious change * [OCDM] OCDM Enhancements * Review comments from Doug * Changes after more review * Address Review comments Co-authored-by: Santhosh Ramani <s.ramani@metrological.com>

* localtracer: Fixes for Messaging refactors * localtracer: use saver mkdtemp

fix height typo's

* displayinfo: Add stress test option * deviceinfo: Add stress tests * Update main.c

[DevInfo] fix build

…agma once (rdkcentral#183)

…on scheme. (rdkcentral#180)

…central#184)

…central#192)

…central#196)

…central#205) Broken by target name change in [5aca10](rdkcentral@5aca10)

…dkcentral#204)

…pull 205) (rdkcentral#206)

Co-authored-by: Pierre Wielders <pierre@wielders.net>

… from thunder (rdkcentral#209)

…l#211)

…rdkcentral#215)

…al#218)

* Cryptography: switch off provisioning option by default * ProvisionProxy: make sure -fPIC in in the pc file

rdkcentral#227) Co-authored-by: Volkan Aslan <v.aslan@metrological.com>

[ocdm] add test app

Correction for CMakeLists.txt of ocdmtest

* Update Client.h * Update Implementation.cpp * Updated all AddRef to the new standard --------- Co-authored-by: Volkan Aslan <v.aslan@metrological.com>

…dkcentral#241) * cryptography: force deprecation declarations to be a warning again * Update open_cdm_impl.h Move up to the new AddRef() --------- Co-authored-by: Pierre Wielders <pierre@wielders.net>

…nto R4_4

Reason for change : L1 test framework for ocdm and run scripts added Test procedure: Run run.sh and check tests are executed and reports generated Risks: Low Signed-off-by: nkader321 <NoorjahanRofina_KaderMohideen@comcast.com>

CLAassistant · 2025-01-23T18:46:32Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ pwielders
✅ Divya-563
✅ HaseenaSainul
✅ MFransen69
✅ bramoosterhuis
✅ sebaszm
✅ dcarr45
✅ volkan-aslan
✅ VeithMetro
❌ nkader321

nkader321 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

rdkcmf-jenkins · 2025-01-23T18:50:03Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 4 files pending identification.

Protex Server Path: /home/blackduck/github/ThunderClientLibraries/290/rdkcentral/ThunderClientLibraries
Commit: 985156c

Report detail: gist'

mhughesacn · 2025-01-23T19:34:13Z

Please append a credit for RDKM to the end of the NOTICE file at top level:

and I will clear the Blackduck test.

pwielders

This is a big PR which is hard to read. Please break it up in smaller chunks.

What I already did see is the removal of dedicates namespaces (Exchange) and location of include files for the include (removal of interface)

There is a strict policy in the code development for Thunder that it is strong typed and specifically indicated. This means that dropping "interface" in the include and the removal of the namespace Exchange is a degradation of code quality! So please revert those changes...

pwielders and others added 30 commits August 29, 2022 17:19

Merge branch 'master' into R4

fb28036

Merge branch 'master' into R4

25d3307

Merge branch 'master' into R4

28cd880

Merge branch 'master' into R4

4778fb6

Merge branch 'master' into R4

6522afb

Merge branch 'master' into R4

a98c4a0

localtracer: Fixes for Messaging refactors (rdkcentral#176)

df2aa95

* localtracer: Fixes for Messaging refactors * localtracer: use saver mkdtemp

Cryptography:test app made it compilable again (rdkcentral#175)

29e141c

fix height typo's

1d1d8ed

Merge pull request rdkcentral#178 from rdkcentral/fix/fix-small-typo's

f57047b

fix height typo's

LocalTracer: Fix line echo.

040e68a

DeviceInfo/DisplayInfo stress tests (rdkcentral#181)

165452b

* displayinfo: Add stress test option * deviceinfo: Add stress tests * Update main.c

[DevInfo] fix build

96939a1

Merge pull request rdkcentral#182 from rdkcentral/development/fixdevinfo

d064426

[DevInfo] fix build

Update C header files with generic ifndef-define structure instead pr…

c846aee

…agma once (rdkcentral#183)

Modified to check mime type in protection metadata to detect encrypti…

4a300a6

…on scheme. (rdkcentral#180)

Modified to fetch secbuf OCDM adapater from external repository. (rdk…

36c1855

…central#184)

[WINDOWS] Get it compiling under windows again..

0968952

Creating GitHub Actions to build ThunderClientLibraries (rdkcentral#188)

de62484

Fixing OCDM project file (rdkcentral#189)

c9e2142

Modified gstreamer ocdm adapter for MediaProperties related fix. (rdk…

9fc2043

…central#192)

[METRICS] Add a new metrics punch through on the OCDM framework. (rdk…

b80f208

…central#196)

[WINDOWS] Fixes for windows (rdkcentral#195)

c68c9f5

[METRICS] Add a new metrics punch through on the OCDM framework. (rdk…

beaf406

…central#196)

Merge branch 'master' into R4

50a8509

Merge branch 'master' into R4

712a130

Merge branch 'master' into R4

5a9dad1

Fixing libdrm target name in compositorclient/RPI/CMakeLists.txt (rdk…

35f6af2

…central#205) Broken by target name change in [5aca10](rdkcentral@5aca10)

[WARNINGFREE] Suppress the ABI changes. We always build full stack. (r…

ff80452

…dkcentral#204)

Divya-563 and others added 19 commits May 23, 2023 10:34

Merge branch 'master' into R4

4bb3224

[DRM] Renaming of the library for CMake (cherry pick did not work on …

97052d8

…pull 205) (rdkcentral#206)

fixing naming convention find cmakes (rdkcentral#207)

2813b8f

localtracer: Align with latest messaging changes (rdkcentral#208)

c88346f

Co-authored-by: Pierre Wielders <pierre@wielders.net>

compositorclient:RPI: Remove Announcements calls, since it is removed…

adffa5c

… from thunder (rdkcentral#209)

Merge branch 'master' into R4

35903e0

Revert the uint32_t -> uint16_t on IHash and ICryptography (rdkcentra…

4b57015

…l#211)

cryptography: move ICryptography.h & INetflixSecurity.h to interfaces (…

2b3c14e

…rdkcentral#215)

update INetflixSecurity namespace based on interface change (rdkcentr…

ba00103

…al#218)

Development/small cmake fixes (rdkcentral#203)

0deedc7

* Cryptography: switch off provisioning option by default * ProvisionProxy: make sure -fPIC in in the pc file

[DEPENDENCIES]Provision proxy was missing Messaging library dependency (

699f6c5

rdkcentral#227) Co-authored-by: Volkan Aslan <v.aslan@metrological.com>

[ocdm] Dispose improvements (rdkcentral#232)

474894b

Merge pull request rdkcentral#233 from rdkcentral/development/ocdmtest

c832de8

[ocdm] add test app

Fixing the conflict of cherry pick

2594a8e

Merge pull request rdkcentral#235 from rdkcentral/development/ocdmtest

7e58718

Correction for CMakeLists.txt of ocdmtest

Development/reference counting (rdkcentral#242)

3600cce

* Update Client.h * Update Implementation.cpp * Updated all AddRef to the new standard --------- Co-authored-by: Volkan Aslan <v.aslan@metrological.com>

cryptography: force deprecation declarations to be a warning again (r…

087ae89

…dkcentral#241) * cryptography: force deprecation declarations to be a warning again * Update open_cdm_impl.h Move up to the new AddRef() --------- Co-authored-by: Pierre Wielders <pierre@wielders.net>

Merge branch 'R4_4' of github.com:rdkcentral/ThunderClientLibraries i…

09a75a8

…nto R4_4

RDK-53574 OCDM client l1test framework

985156c

Reason for change : L1 test framework for ocdm and run scripts added Test procedure: Run run.sh and check tests are executed and reports generated Risks: Low Signed-off-by: nkader321 <NoorjahanRofina_KaderMohideen@comcast.com>

pwielders requested changes Feb 2, 2025

View reviewed changes

NRofina marked this pull request as draft February 3, 2025 11:00

MFransen69 closed this Jan 13, 2026

github-actions bot locked and limited conversation to collaborators Jan 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

L1tests ocdm #290

L1tests ocdm #290

Uh oh!

NRofina commented Jan 23, 2025

Uh oh!

CLAassistant commented Jan 23, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins commented Jan 23, 2025

Uh oh!

mhughesacn commented Jan 23, 2025

Uh oh!

pwielders left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

L1tests ocdm #290

L1tests ocdm #290

Uh oh!

Conversation

NRofina commented Jan 23, 2025

Uh oh!

CLAassistant commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 23, 2025

Uh oh!

mhughesacn commented Jan 23, 2025

Uh oh!

pwielders left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

CLAassistant commented Jan 23, 2025 •

edited

Loading

pwielders left a comment •

edited

Loading