Skip to content

Conversation

@NRofina
Copy link

@NRofina NRofina commented Jan 28, 2025

Reason for change : run.sh script added to install dependencies and run tests
Test procedure: Run run.sh and check tests are executed and reports generated
Risks: Low
Signed-off-by: nkader321 NoorjahanRofina_KaderMohideen@comcast.com

Reason for change : run.sh script added to install dependencies and run tests
Test procedure: Run run.sh and check tests are executed and reports generated
Risks: Low
Signed-off-by: nkader321 <NoorjahanRofina_KaderMohideen@comcast.com>
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ VeithMetro
❌ nkader321


nkader321 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pwielders pwielders requested a review from VeithMetro February 2, 2025 06:56

on:
pull_request:
branches: [ develop, main ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have either develop or main branches in this repo, and usually we run all workflows on both pull requests and pushes to master.

But in this case, it looks like the intention is to test code for R5_1, since all other repositories are checked out for these branches, correct?


jobs:
build:
runs-on: ubuntu-latest
Copy link
Contributor

@VeithMetro VeithMetro Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be safer to specific the Ubuntu version here, e.g. ubuntu-24.04

There was a bug once which could lead to latest being interpreted differently across various workflows, plus it is easier to maintain without the Ubuntu version changing on its own, which could make some packages no longer available

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will update

@NRofina NRofina marked this pull request as draft February 3, 2025 11:03
@MFransen69 MFransen69 closed this Jan 13, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants