RDK-60621 - Data Collection Through T2 Events For Components Logging To btmgrlog.txt #42
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,60 @@ | ||||||
| /* | ||||||
| * If not stated otherwise in this file or this component's LICENSE file the | ||||||
|
Check failure on line 2 in include/telemetry/bt-telemetry.h
|
||||||
| * following copyright and licenses apply: | ||||||
| * | ||||||
| * Copyright 2016 RDK Management | ||||||
| * | ||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| * you may not use this file except in compliance with the License. | ||||||
| * You may obtain a copy of the License at | ||||||
| * | ||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| * | ||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| * See the License for the specific language governing permissions and | ||||||
| * limitations under the License. | ||||||
| */ | ||||||
| /* | ||||||
| * @file bt-telemetry.h | ||||||
| * Includes telemetry wrapper utilities for Bluetooth Core and Bluetooth Manager | ||||||
| */ | ||||||
|
|
||||||
| #ifndef __BT_TELEMETRY_H__ | ||||||
| #define __BT_TELEMETRY_H__ | ||||||
|
|
||||||
| /** | ||||||
| * @brief Initialize telemetry with component name | ||||||
| * | ||||||
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| * @param name Component name for telemetry identification | ||||||
| */ | ||||||
| void telemetry_init(char* name); | ||||||
|
|
||||||
| /** | ||||||
| * @brief Send marker with string value to T2 | ||||||
| * | ||||||
| * @param marker Telemetry marker/event name (use _split suffix for split markers) | ||||||
| * @param value String value to send | ||||||
| */ | ||||||
| void telemetry_event_s(const char* marker, char* value); | ||||||
|
There was a problem hiding this comment. The
Suggested change
|
||||||
|
|
||||||
| /** | ||||||
| * @brief Send marker with integer value to T2 or report count based markers | ||||||
| * | ||||||
| * @param marker Telemetry marker/event name | ||||||
| * @param value Integer value to send | ||||||
| */ | ||||||
| void telemetry_event_d(const char* marker, int value); | ||||||
|
|
||||||
| /** | ||||||
| * @brief Send marker with double value to T2 | ||||||
| * | ||||||
| * @param marker Telemetry marker/event name (use _split suffix for split markers) | ||||||
| * @param value Double value to send | ||||||
| * | ||||||
| * Usage: telemetry_event_f("HWREV_split", 2.2); | ||||||
| */ | ||||||
| void telemetry_event_f(const char* marker, double value); | ||||||
|
|
||||||
| #endif /* __BT_TELEMETRY_H__ */ | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
|
Check failure on line 2 in src/bt-telemetry.c
|
||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2016 RDK Management | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| /* | ||
| * bt-telemetry.c | ||
| * Implementation of telemetry wrapper utilities for Bluetooth Core and Bluetooth Manager | ||
| */ | ||
|
|
||
| #include <stdio.h> | ||
|
|
||
| #ifdef HAVE_TELEMETRY_MSGSENDER | ||
| #include <telemetry_busmessage_sender.h> | ||
| #endif | ||
|
|
||
| #include "btrCore_logger.h" | ||
| #include "bt-telemetry.h" | ||
|
|
||
| /** | ||
| * @brief Initialize telemetry with component name | ||
| */ | ||
| void telemetry_init(char* name) | ||
| { | ||
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (name == NULL) { | ||
| BTRCORELOG_ERROR("T2: Failed to initialize telemetry - component name is NULL\n"); | ||
| return; | ||
| } | ||
|
|
||
| #ifdef HAVE_TELEMETRY_MSGSENDER | ||
| BTRCORELOG_INFO("T2: Initializing telemetry with component name=\"%s\"\n", name); | ||
| t2_init(name); | ||
| #else | ||
| BTRCORELOG_INFO("T2: telemetry sender disabled - telemetry_init skipped for \"%s\"\n", name); | ||
| #endif | ||
| } | ||
|
|
||
| /** | ||
| * @brief Send marker with string value to T2 | ||
| */ | ||
| void telemetry_event_s(const char* marker, char* value) | ||
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| if (marker == NULL) { | ||
| BTRCORELOG_ERROR("T2: telemetry_event_s - marker is NULL\n"); | ||
| return; | ||
| } | ||
| if (value == NULL) { | ||
| BTRCORELOG_ERROR("T2: telemetry_event_s - value is NULL\n"); | ||
| return; | ||
| } | ||
|
|
||
| #ifdef HAVE_TELEMETRY_MSGSENDER | ||
| T2ERROR t2error = t2_event_s(marker, value); | ||
| if (t2error != T2ERROR_SUCCESS) { | ||
| BTRCORELOG_ERROR("t2_event_s(\"%s\", \"%s\") returned error code %d\n", marker, value, t2error); | ||
| } | ||
| #else | ||
| BTRCORELOG_INFO("T2: telemetry sender disabled - telemetry_event_s skipped for %s\n", marker); | ||
| #endif | ||
| } | ||
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * @brief Send marker with integer value to T2 or report count based markers | ||
| */ | ||
| void telemetry_event_d(const char* marker, int value) | ||
| { | ||
| if (marker == NULL) { | ||
| BTRCORELOG_ERROR("T2: telemetry_event_d - marker is NULL\n"); | ||
| return; | ||
| } | ||
|
|
||
| #ifdef HAVE_TELEMETRY_MSGSENDER | ||
| T2ERROR t2error = t2_event_d(marker, value); | ||
| if (t2error != T2ERROR_SUCCESS) { | ||
| BTRCORELOG_ERROR("t2_event_d(\"%s\", %d) returned error code %d\n", marker, value, t2error); | ||
| } | ||
| #else | ||
| BTRCORELOG_INFO("T2: telemetry sender disabled - telemetry_event_d skipped for %s\n", marker); | ||
| #endif | ||
| } | ||
|
|
||
| /** | ||
| * @brief Send marker with double value to T2 | ||
| */ | ||
| void telemetry_event_f(const char* marker, double value) | ||
| { | ||
| if (marker == NULL) { | ||
| BTRCORELOG_ERROR("T2: telemetry_event_f - marker is NULL\n"); | ||
| return; | ||
| } | ||
|
|
||
| #ifdef HAVE_TELEMETRY_MSGSENDER | ||
| T2ERROR t2error = t2_event_f(marker, value); | ||
| if (t2error != T2ERROR_SUCCESS) { | ||
| BTRCORELOG_ERROR("t2_event_f(\"%s\", %f) returned error code %d\n", marker, value, t2error); | ||
| } | ||
| #else | ||
| BTRCORELOG_INFO("T2: telemetry sender disabled - telemetry_event_f skipped for %s\n", marker); | ||
| #endif | ||
| } | ||
ANANTHMARIMUTHU marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation of TELEMETRY_CFLAGS is inconsistent with the previous line. It should align with the TELEMETRY_MSGLIBS assignment above it.