Thread btrMgr_IncomingConnectionAuthentication to unblock device status callback#70
Draft
Thread btrMgr_IncomingConnectionAuthentication to unblock device status callback#70
Conversation
- Add BTRMGR_AuthenticationThreadData_t structure to pass data to thread - Add btrMgr_IncomingConnectionAuthenticationThread as thread function - Add btrMgr_IncomingConnectionAuthenticationAsync to launch thread - Update device status callback to use async version - Keep original function for synchronous startup case Co-authored-by: natrajmuthusamy <52849136+natrajmuthusamy@users.noreply.github.com>
Co-authored-by: natrajmuthusamy <52849136+natrajmuthusamy@users.noreply.github.com>
- Fix inconsistent indentation in thread function - Add comments explaining thread safety considerations - Add comment about g_thread_unref usage Co-authored-by: natrajmuthusamy <52849136+natrajmuthusamy@users.noreply.github.com>
Co-authored-by: natrajmuthusamy <52849136+natrajmuthusamy@users.noreply.github.com>
Complete implementation of threaded authentication for incoming connections Co-authored-by: natrajmuthusamy <52849136+natrajmuthusamy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Run btrMgr_IncomingConnectionAuthentication in a separate thread
Thread btrMgr_IncomingConnectionAuthentication to unblock device status callback
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
btrMgr_IncomingConnectionAuthenticationblocks for up to 20 seconds polling for UI response, preventing other device status events from being processed.Changes
New async implementation:
btrMgr_IncomingConnectionAuthenticationAsync()- launches authentication in separate GThreadbtrMgr_IncomingConnectionAuthenticationThread()- thread function containing authentication logicBTRMGR_AuthenticationThreadData_t- structure to pass device status data to threadCall site updates:
Updated 3 locations in
btrMgr_DeviceStatusCb()to use async version:Preserved synchronous function:
Original
btrMgr_IncomingConnectionAuthentication()kept for startup/initialization where blocking is acceptable.Example
Before:
After:
Thread Safety
Accesses global variables (
gEventRespReceived,gAcceptConnection,gListOfPairedDevices) without mutexes, maintaining existing thread safety characteristics. Comment added noting future hardening opportunity.Deliverables
btrmgr_threading.patch- Git patch fileTHREADING_NOTES.md- Technical documentationIMPLEMENTATION_SUMMARY.md- Implementation details✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.