RDK-60621 - Data Collection Through T2 Events For Components Logging To btmgrlog.txt by ANANTHMARIMUTHU · Pull Request #75 · rdkcentral/bluetooth_mgr

ANANTHMARIMUTHU · 2026-02-20T08:32:33Z

No description provided.

rebase

Copilot

Pull request overview

This pull request adds telemetry instrumentation to the Bluetooth Manager (btrMgr) to track various Bluetooth operations and error conditions. The changes integrate a telemetry library (bt-telemetry.h) and add 22 telemetry markers throughout the codebase to monitor connection, pairing, unpairing, discovery, and error events.

Changes:

Added bt-telemetry.h include and initialized telemetry in BTRMGR_Init
Instrumented 22 telemetry markers for tracking BT operations (connect/disconnect, pair/unpair, discovery errors, adapter errors, GamePad RFC values)
Added test simulation function (commented out with #if 0) to verify all telemetry markers
Changed RFC GamePad parameter logging from DEBUG to INFO level

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ifce/btrMgr.c

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ifce/btrMgr.c

ANANTHMARIMUTHU

review

rebase

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ifce/btrMgr.c

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ifce/btrMgr.c

Copilot · 2026-02-26T12:30:00Z

src/ifce/btrMgr.c

+	char btmgr_name[] = "btmgr";
+	telemetry_init(btmgr_name);
+	/* Run telemetry test simulation if BTRMGR_TELEMETRY_TEST=1 is set */
+    // btrMgr_TelemetryTestSimulation();


Commented-out function call. This commented-out call to btrMgr_TelemetryTestSimulation should be removed. Commented-out code reduces code readability and should not be committed to the codebase. If this is needed for future testing, consider using a feature flag or environment variable check instead.

Suggested change

// btrMgr_TelemetryTestSimulation();

src/ifce/btrMgr.c

unitTest/support/include/bt-telemetry.h

src/ifce/btrMgr.c

ANANTHMARIMUTHU

review

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T08:39:00Z

src/ifce/btrMgr.c

        //Inside this function there is a failure logs so, did not any failures logs here.
        btrMgr_GetDeviceDetails(ahBTRMgrDevHdl,&stDeviceInfo);
+        const char* lpcDeviceName = stDeviceInfo.pcDeviceName ? stDeviceInfo.pcDeviceName : "Unknown";

        if (lenBtrCoreRet != enBTRCoreSuccess) {
            //This is telemetry log. If we change this print,need to change and configure the telemetry string in xconf server.
+            char buffer[256];
+            snprintf(buffer, sizeof(buffer), "Failed to Disconnect from this device - Confirmed name,class,apperance,modalias: %s,%u,%u,v%04Xp%04Xd%04X",
+                lpcDeviceName, stDeviceInfo.ui32DevClassBtSpec, stDeviceInfo.ui16DevAppearanceBleSpec,
+                stDeviceInfo.ui32ModaliasVendorId, stDeviceInfo.ui32ModaliasProductId, stDeviceInfo.ui32ModaliasDeviceId);
+            telemetry_event_s("BTDiscFail_split", buffer);
            BTRMGRLOG_ERROR ("Failed to Disconnect from this device - Confirmed name,class,apperance,modalias: %s,%u,%u,v%04Xp%04Xd%04X\n",
-            stDeviceInfo.pcDeviceName, stDeviceInfo.ui32DevClassBtSpec, stDeviceInfo.ui16DevAppearanceBleSpec,
+            lpcDeviceName, stDeviceInfo.ui32DevClassBtSpec, stDeviceInfo.ui16DevAppearanceBleSpec,
            stDeviceInfo.ui32ModaliasVendorId, stDeviceInfo.ui32ModaliasProductId, stDeviceInfo.ui32ModaliasDeviceId);
            BTRMGRLOG_ERROR ("Disconnect failure device MAC %s\n", stDeviceInfo.pcDeviceAddress);


Disconnect telemetry/log formatting has the same issue as connect/unpair: stDeviceInfo is not zero-initialized and the result of btrMgr_GetDeviceDetails is ignored. If that call fails, pcDeviceName/pcDeviceAddress may be garbage and the telemetry payload may contain undefined values. Please MEMSET_S + check the return, and fall back to safe defaults before calling snprintf/telemetry_event_*.

Copilot · 2026-02-27T08:39:01Z

src/ifce/btrMgr.c

+/*
+ * TEST SIMULATION FUNCTION FOR TELEMETRY MARKERS
+ * This function simulates all 22 telemetry markers for testing
+ * Set BTRMGR_TELEMETRY_TEST=1 environment variable to enable testing
+ */
+#if 1
+ STATIC void
+btrMgr_TelemetryTestSimulation (


The telemetry test simulation block is compiled in unconditionally (#if 1) despite the comment saying it should be enabled via an environment variable. This risks shipping a test-only routine in production builds. Please gate this behind a compile-time flag (e.g., #ifdef BTRMGR_TELEMETRY_TEST) and/or implement the documented env-var check inside the function.

Copilot · 2026-02-27T08:39:01Z

src/ifce/btrMgr.c

 #include "btrMgr_SysDiag.h"
 #include "btrMgr_Columbo.h"
 #include "btrMgr_LEOnboarding.h"
-
+#include "bt-telemetry.h"


bt-telemetry.h is included unconditionally, but this repository does not provide that header in the normal include paths (it only exists under unitTest/support/include). This will break non-unit-test builds unless the header/library is guaranteed to come from an external dependency. Please add a proper configure-time check + conditional include (or ship/install the header and link the telemetry library when enabled).

Copilot · 2026-02-27T08:39:01Z

src/ifce/btrMgr.c

    //Inside this function there is a failure logs so, did not any failures logs here.
    btrMgr_GetDeviceDetails(ahBTRMgrDevHdl,&stDeviceInfo);

    if (enBTRCoreSuccess != BTRCore_UnPairDevice(ghBTRCoreHdl, ahBTRMgrDevHdl)) {
        //This is telemetry log. If we change this print,need to change and configure the telemetry string in xconf server.
+        char buffer[256];
+        snprintf(buffer, sizeof(buffer), "Failed to unpair name,class,apperance,modalias: %s,%u,%u,v%04Xp%04Xd%04X",
+            stDeviceInfo.pcDeviceName, stDeviceInfo.ui32DevClassBtSpec, stDeviceInfo.ui16DevAppearanceBleSpec,
+            stDeviceInfo.ui32ModaliasVendorId, stDeviceInfo.ui32ModaliasProductId, stDeviceInfo.ui32ModaliasDeviceId);
+        telemetry_event_s("BTUnpairFail_split", buffer);


Unpair telemetry/log formatting uses stDeviceInfo without checking whether btrMgr_GetDeviceDetails succeeded, and without NULL-safety for pcDeviceName/pcDeviceAddress. Please zero-init stDeviceInfo, check the return from btrMgr_GetDeviceDetails, and use safe fallbacks ("Unknown" / 0) when details are unavailable to avoid crashes and bogus telemetry payloads.

ANANTHMARIMUTHU and others added 24 commits February 3, 2026 17:00

Update Makefile.am

39bb327

Update Makefile.am

91442e0

Update btrMgr.c

5658e8f

Update btrMgr.c

ab7564f

Update Makefile.am

a3ff4d7

Update Makefile.am

6b947dc

Update Makefile.am

8b8aa5c

Update Makefile.am

f086b04

Update Makefile.am

59be6d7

btmgr t2 event implementation

ea3de1f

btmgr t2 event implementation

f15b35e

btmgr t2 event implementation

9cef6a7

btmgr t2 event implementation

f754267

btmgr t2 event implementation

bd6b116

btmgr t2 event implementation

0365fd2

btmgr t2 event implementation

b3b98d7

btmgr t2 event implementation

3870c39

btmgr t2 event implementation

68d77a9

btmgr t2 event implementation

945f668

Merge pull request #72 from rdkcentral/develop

85c9c1a

rebase

btmgr t2 event implementation

f4bae73

btmgr t2 event implementation

2ca83c3

btmgr t2 event implementation

32120a3

btmgr t2 event implementation

901d6b3

ANANTHMARIMUTHU requested a review from a team as a code owner February 20, 2026 08:32

Copilot AI review requested due to automatic review settings February 20, 2026 08:32

Copilot started reviewing on behalf of ANANTHMARIMUTHU February 20, 2026 08:33 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

amarim184 added 2 commits February 20, 2026 10:37

btmgr t2 event implementation

85b6f88

btmgr t2 event implementation

8c52727

Copilot AI review requested due to automatic review settings February 20, 2026 13:26

Copilot started reviewing on behalf of ANANTHMARIMUTHU February 20, 2026 13:27 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

src/ifce/btrMgr.c Outdated Show resolved Hide resolved

ANANTHMARIMUTHU commented Feb 24, 2026

View reviewed changes

ANANTHMARIMUTHU linked an issue Feb 24, 2026 that may be closed by this pull request

RDK-60621 t2 event #79

Open

ANANTHMARIMUTHU and others added 2 commits February 24, 2026 18:18

Merge pull request #80 from rdkcentral/develop

ca9b76c

rebase

btmgr t2 event implementation

fed0356

Copilot AI review requested due to automatic review settings February 25, 2026 13:07

Copilot started reviewing on behalf of ANANTHMARIMUTHU February 25, 2026 13:08 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

amarim184 added 2 commits February 26, 2026 08:09

btmgr t2 event implementation

0dbb8d1

btmgr t2 event implementation

1adb667

Copilot AI review requested due to automatic review settings February 26, 2026 12:23

Copilot started reviewing on behalf of ANANTHMARIMUTHU February 26, 2026 12:24 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

btmgr t2 event implementation

1a71a04

ANANTHMARIMUTHU commented Feb 27, 2026

View reviewed changes

btmgr t2 event implementation

f12e479

Copilot AI review requested due to automatic review settings February 27, 2026 08:32

Copilot started reviewing on behalf of ANANTHMARIMUTHU February 27, 2026 08:32 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

ANANTHMARIMUTHU changed the title ~~Rdk 60621~~ RDK-60621 - Data Collection Through T2 Events For Components Logging To btmgrlog.txt Feb 27, 2026

Conversation

ANANTHMARIMUTHU commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

ANANTHMARIMUTHU left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ANANTHMARIMUTHU left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants