Skip to content

New ignore file and reworked fossid workflow to reduce false positives#31

Open
danielsoden0404 wants to merge 4 commits intodevelopfrom
fix/fossid_false_positives_gerrit_github
Open

New ignore file and reworked fossid workflow to reduce false positives#31
danielsoden0404 wants to merge 4 commits intodevelopfrom
fix/fossid_false_positives_gerrit_github

Conversation

@danielsoden0404
Copy link

In this change I used a script to generate a list of ids of open source Gerrit repos to ignore and included the rdkcentral and rdkcmf ignore wildcards.

I also reworked the workflow file according to advice from fossid in that the image we should be using is fossid-toolbox for diffscan, not fossid-cicd. From here I adjusted some of the flags accordingly

Copilot AI review requested due to automatic review settings February 25, 2026 12:09
@danielsoden0404 danielsoden0404 requested a review from a team as a code owner February 25, 2026 12:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the FossID pre-merge diff scan setup to reduce false positives by switching to the recommended fossid-toolbox image/CLI and replacing the previous ignore-file approach with a generated ignore list.

Changes:

  • Added a generated ignored_projects_list containing Gerrit OSS project IDs and GitHub org wildcards to ignore.
  • Removed the older ignore_projects_fossid ignore file.
  • Reworked the FossID GitHub Actions workflow to use quay.io/fossid/fossid-toolbox and updated CLI flags/file paths accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
ignored_projects_list Introduces the new generated ignore list used to reduce false positives.
ignore_projects_fossid Deletes the previous ignore file in favor of the new list.
.github/workflows/fossid_integration_stateless_diffscan.yml Switches workflow execution to fossid-toolbox/fossid diffscan and updates ignore-projects handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 28 to +35
- name: Checkout ignore projects file
uses: actions/checkout@v4
with:
repository: rdkcentral/build_tools_workflows
sparse-checkout: |
ignore_projects_fossid
ref: develop
path: tools
token: ${{ secrets.RDKCM_RDKE }}
- name: Run fossid-cicd
repository: rdkcentral/build_tools_workflows
sparse-checkout: |
ignored_projects_list
ref: develop
path: tools
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checkout pulls from rdkcentral/build_tools_workflows without providing a token. In this repo, other workflows use ${{ secrets.RDKCM_RDKE }} when checking out rdkcentral/build_tools_workflows, and without a token this step can fail (private repo) or hit stricter rate limits. Consider adding a token: input (or making it a required secret for this workflow) for consistency and reliability.

Copilot uses AI. Check for mistakes.
Comment on lines 28 to +34
- name: Checkout ignore projects file
uses: actions/checkout@v4
with:
repository: rdkcentral/build_tools_workflows
sparse-checkout: |
ignore_projects_fossid
ref: develop
path: tools
token: ${{ secrets.RDKCM_RDKE }}
- name: Run fossid-cicd
repository: rdkcentral/build_tools_workflows
sparse-checkout: |
ignored_projects_list
ref: develop
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository now includes an ignored_projects_list file at the repo root, but the workflow ignores it and instead checks out tools/ignored_projects_list from rdkcentral/build_tools_workflows@develop. This can lead to the checked-in list going stale/confusing. Either remove the root file, or update the workflow to use the in-repo list (and drop the extra checkout) so there is a single source of truth.

Copilot uses AI. Check for mistakes.
@mhughesacn
Copy link

  1. Copilot has a comment about ignored_projects_list being in two different places.  Checked in at top level but the yml workflow uses tools/ignored_project_list - is this OK?
  2. Also there is a duplicate in the ignore file - Copilot again.
  3. Can the last two entries in the ignore file go on top as extra entries will likely be appended?
  4. The ignores are just magic numbers as required by fossid. It would be good to include the URLs as well - is a comment possible (?) and if not, to have the projects in a separate file also checked in here.

danielsoden0404 and others added 2 commits March 3, 2026 14:07
7de58ed6dfb35940bf3521ed00000000

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 3, 2026 14:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants