Skip to content

RDKB-63015: Fix to support repo without autogen script#32

Merged
GoutamD2905 merged 1 commit intodevelopfrom
feature/native-build-configure
Mar 3, 2026
Merged

RDKB-63015: Fix to support repo without autogen script#32
GoutamD2905 merged 1 commit intodevelopfrom
feature/native-build-configure

Conversation

@guruchandru
Copy link
Contributor

Updating the build_native.sh to use autoreconf when autogen.sh is not available but configure.ac is available

Copilot AI review requested due to automatic review settings March 2, 2026 21:47
@guruchandru guruchandru requested a review from a team as a code owner March 2, 2026 21:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the native component build flow to better handle autotools-based repositories that don’t ship an autogen.sh, by attempting to generate configure from autotools inputs.

Changes:

  • Add an autoreconf fallback in build_component_autotools() when autogen.sh is missing and configure has not been generated.
  • Gate the fallback on presence of configure.ac.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +243 to +246
elif [[ ! -f "./configure" ]] && [[ -f "./configure.ac" ]]; then
# No autogen.sh and no configure, but configure.ac exists
# Run autoreconf to generate configure script
step "Running autoreconf to generate configure script"
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoreconf fallback only checks for configure.ac. Some autotools projects use configure.in instead; in that case this branch is skipped and the next step tries to run ./configure even though it was never generated, causing an immediate build failure. Consider treating configure.in the same as configure.ac (or failing early with a clear error if neither is present and ./configure is missing).

Copilot uses AI. Check for mistakes.
Updating the build_native.sh to use autoreconf when
autogen.sh is not available but configure.ac is available
@guruchandru guruchandru force-pushed the feature/native-build-configure branch from 6b01785 to c7b6534 Compare March 2, 2026 22:55
@GoutamD2905 GoutamD2905 merged commit 6f84836 into develop Mar 3, 2026
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants