RDKBNETWOR-84: DSLite feature integration with WanManager (Wg network…

[devinmungan]

…11 development)

• RDKBNETWOR-85 : DHCP Manager changes for option 64

• adding endpoint name param to DHCP_MGR_IPV6_MSG IPC struct

[Copilot]

Pull request overview

This PR integrates DSLite feature support with WanManager by adding endpoint name information to the IPv6 DHCP manager IPC message structure, specifically to support DHCP option 64 handling as mentioned in RDKBNETWOR-85.

Key Changes:

• Added endpointName field to the DHCP_MGR_IPV6_MSG struct to enable passing endpoint information between DHCP manager and WAN manager components

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sichevoi]

Would be the same aftr vs. endpoint conundrum here ;)

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The MAP_TYPE enum is defined unconditionally but is only used within the ipc_map_data_t structure. If the code is compiled without FEATURE_MAPT or MAPT_UNIFICATION_ENABLED defined, the ipc_dhcpv6_data_t won't include the map field (line 181 is conditionally compiled), but the enum and structure definitions will still be present. For consistency and to avoid unused type definitions, consider either removing the conditional compilation from line 180-182, or adding it to the MAP_TYPE enum and ipc_map_data_t structure definitions as well.

Suggested change

	#if defined(FEATURE_MAPT) || defined(MAPT_UNIFICATION_ENABLED)
	typedef enum _MAP_TYPE
	{
	MAP_TYPE_UNKNOWN = 0,
	MAP_TYPE_MAPE,
	MAP_TYPE_MAPT
	}MAP_TYPE;
	#endif

[Copilot]

The map field and its associated boolean flags (maptAssigned, mapeAssigned) are now unconditionally present in DHCP_MGR_IPV6_MSG. However, the corresponding field in ipc_dhcpv6_data_t structure (line 181) still guards the map data with preprocessor directives (FEATURE_MAPT || MAPT_UNIFICATION_ENABLED). This inconsistency means that when FEATURE_MAPT and MAPT_UNIFICATION_ENABLED are not defined, ipc_dhcpv6_data_t won't have the mapt field but DHCP_MGR_IPV6_MSG will have the map field. This could lead to confusion and potential compilation issues when translating between these structures. Either both structures should unconditionally include the MAP-related fields, or both should use the same conditional compilation guards.

[Copilot]

The field name has been changed from 'mapt' to 'map' in the DHCP_MGR_IPV6_MSG structure, but the corresponding field in the ipc_dhcpv6_data_t structure (line 181) is still named 'mapt'. This naming inconsistency is confusing and makes the codebase harder to maintain. Both structures now use ipc_map_data_t and should use consistent field naming.

Suggested change

	ipc_map_data_t map;
	ipc_map_data_t mapt;