RDKEMW-8587: consume the config variables using dlsym() in MW. #168

santoshcomcast · 2025-10-30T12:00:19Z

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587
Risks: High
Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

apatel859 · 2025-11-03T14:59:34Z

ds/audioOutputPortConfig.cpp

+				printf("%d:%s: kAudioConfigs is defined and loaded kConfigs1 = %p\n", __LINE__, __func__, kConfigs1);
+            }
+            else {
+                INT_ERROR("kAudioConfigs is not defined\r\n");


why two seprate error line? combined to 1

apatel859 · 2025-11-03T15:03:11Z

ds/audioOutputPortConfig.cpp

+
+static dsAudioTypeConfig_t  *kConfigs1 = NULL;
+static dsAudioPortConfig_t  *kPorts1 = NULL;
+int *pKConSize, *pKPortSize;


use consistency in names pKConSize -> pKConfigSize as most of the places you have use config. Also there is not significance of 1 as suffix, use better names

Updated the code

ds/audioOutputPortConfig.cpp

rdkcmf-jenkins · 2025-11-05T11:20:15Z

ds/audioOutputPortConfig.cpp

+	}
+	/*
+	* Initialize Audio portTypes (encodings, compressions etc.)
+	* and its port instances (db, level etc)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Explicit null dereferenced

Dereferencing null pointer "configuration.pKConfigSize".

Medium Impact, CWE-476
FORWARD_NULL

ds/audioOutputPortConfig.cpp

rdkcmf-jenkins · 2025-11-05T11:20:16Z

ds/audioOutputPortConfig.cpp

+
+        void *dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);
+        if (dllib) {
+            config->pKConfigs = (dsAudioTypeConfig_t *) dlsym(dllib, searchVaribles[0]);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "&searchVaribles[2]" to format specifier "%s" was expected to have type "char *" but has type "char const **".

Medium Impact, CWE-686
PRINTF_ARGS

ds/audioOutputPortConfig.cpp

santoshcomcast

I have addressed all review comments.
Can you please review?

rdkcmf-jenkins · 2025-11-05T13:15:21Z

ds/audioOutputPortConfig.cpp

+	}
+	else
+	{
+		INT_ERROR("Invalid kAudioConfigs or kAudioPorts, kConfig_size_local, kPort_size_local\n");


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Out-of-bounds access

Overrunning array "searchVaribles" of 4 8-byte elements by passing it to a function which accesses it at element index 4 (byte offset 39).

High Impact, CWE-119
OVERRUN

rdkcmf-jenkins · 2025-11-05T13:15:22Z

ds/audioOutputPortConfig.cpp

+	}
+	/*
+	* Initialize Audio portTypes (encodings, compressions etc.)
+	* and its port instances (db, level etc)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Explicit null dereferenced

Dereferencing null pointer "configuration.pKConfigSize".

Medium Impact, CWE-476
FORWARD_NULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoDeviceConfig.cpp

+	#endif
+
 	/*
 	 * Initialize Video Devices (supported DFCs etc.)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Explicit null dereferenced

Dereferencing null pointer "pKVideoDeviceConfigs_size".

Medium Impact, CWE-476
FORWARD_NULL

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "pKVideoDeviceConfigs[i].numSupportedDFCs" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "j" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-11T15:39:35Z

ds/videoOutputPortConfig.cpp

+   	 			dsVideoResolution_t  pixelResolution;           ///< The resolution associated with the name
+    			dsVideoAspectRatio_t  aspectRatio;              ///< The associated aspect ratio
+    			dsVideoStereoScopicMode_t  stereoScopicMode;    ///< The associated stereoscopic mode
+    			dsVideoFrameRate_t  frameRate;                  ///< The associated frame rate


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "typeCfg->numSupportedResolutions" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-12T12:33:34Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "pKVideoDeviceConfigs[i].numSupportedDFCs" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-12T12:33:34Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "j" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-12T12:33:34Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-12T12:33:34Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-12T12:33:35Z

ds/videoOutputPortConfig.cpp

+   	 			dsVideoResolution_t  pixelResolution;           ///< The resolution associated with the name
+    			dsVideoAspectRatio_t  aspectRatio;              ///< The associated aspect ratio
+    			dsVideoStereoScopicMode_t  stereoScopicMode;    ///< The associated stereoscopic mode
+    			dsVideoFrameRate_t  frameRate;                  ///< The associated frame rate


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "typeCfg->numSupportedResolutions" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/frontPanelConfig.cpp

+			   configuration->pKTextDisplays[i].levels,
+			   configuration->pKTextDisplays[i].maxHorizontalIterations,
+			   configuration->pKTextDisplays[i].maxVerticalIterations,
+			   configuration->pKTextDisplays[i].supportedCharacters,


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "configuration->pKTextDisplays[i].supportedCharacters" to format specifier "%d" was expected to have type "int" but has type "char const *".

Medium Impact, CWE-686
PRINTF_ARGS

Can we fix this issue.

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "pKVideoDeviceConfigs[i].numSupportedDFCs" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "j" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/videoDeviceConfig.cpp

+		}
+	}
+	else
+	{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/videoDeviceConfig.cpp

+	else
+	{
+		INT_ERROR("%d:%s:  kVideoDeviceConfigs is NULL and  videoDeviceConfigs_size is -1\n", __LINE__, __func__);
+	}


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "i" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

rdkcmf-jenkins · 2025-11-13T06:50:14Z

ds/videoOutputPortConfig.cpp

+   	 			dsVideoResolution_t  pixelResolution;           ///< The resolution associated with the name
+    			dsVideoAspectRatio_t  aspectRatio;              ///< The associated aspect ratio
+    			dsVideoStereoScopicMode_t  stereoScopicMode;    ///< The associated stereoscopic mode
+    			dsVideoFrameRate_t  frameRate;                  ///< The associated frame rate


Coverity Issue - Invalid type in argument to printf format specifier

Argument "typeCfg->numSupportedResolutions" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

yuvaramachandran-gurusamy · 2025-11-14T08:53:23Z

ds/audioOutputPortConfig.cpp

 	return supportedTypes;
 }

+#if 0


@santoshcomcast , Can we remove this

yuvaramachandran-gurusamy · 2025-11-14T08:54:30Z

ds/audioOutputPortConfig.cpp

+	INT_INFO("%d:%s: pKPortSize = %p\n", __LINE__, __func__, config->pKPortSize);
+
+	INT_INFO("\n\n=========================================================================================================================\n\n");
+	if(config->pKConfigs != NULL && *(config->pKConfigSize) != -1)


Please add null check for pKConfigs and pKConfigSize since it is pointer variable

yuvaramachandran-gurusamy · 2025-11-14T08:55:15Z

ds/audioOutputPortConfig.cpp

+	{
+		INT_ERROR("%d:%s: kAudioConfigs is NULL and kConfig_size_local is -1\n", __LINE__, __func__);
+	}
+	if(config->pKPorts != NULL && *(config->pKPortSize) != -1)


Please add null check for pKPortSize since it is pointer variable

yuvaramachandran-gurusamy · 2025-11-14T08:57:32Z

ds/audioOutputPortConfig.cpp

+		{
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[2]);
+			ret = searchConfigs((void **)&configuration.pKConfigSize, (char *)searchVaribles[2]);
+			if(ret == false)


Do we need fallbacks to default configs if pKConfigSize, pKPorts and pKPortSize are not present in the library

We can not mix the new and old configs.

yuvaramachandran-gurusamy · 2025-11-14T08:58:15Z

ds/audioOutputPortConfig.cpp

-			const dsAudioPortConfig_t *port = &kPorts[i];
+	 	* set up ports based on kPorts[]
+	 	*/
+		for (size_t i = 0; i < *(configuration.pKPortSize); i++) {


Please add NULL check here as well.

yuvaramachandran-gurusamy · 2025-11-14T09:02:49Z

ds/videoOutputPortConfig.cpp

+		for (size_t i = 0; i < *(config->pKVideoPortConfigs_size); i++)
+		{
+			const dsVideoPortTypeConfig_t *typeCfg = &(config->pKConfigs[i]);
+			#if 0


Can we remove this

yuvaramachandran-gurusamy · 2025-11-14T09:03:10Z

ds/videoOutputPortConfig.cpp

+			INT_INFO("%d:%s: typeCfg->hdcpSupported = %d\n", __LINE__, __func__, typeCfg->hdcpSupported);
+			INT_INFO("%d:%s: typeCfg->restrictedResollution = %d\n", __LINE__, __func__, typeCfg->restrictedResollution);
+			INT_INFO("%d:%s: typeCfg->numSupportedResolutions= %d\n", __LINE__, __func__, typeCfg->numSupportedResolutions);
+			#if 0


Can we remove this

yuvaramachandran-gurusamy · 2025-11-14T09:03:45Z

ds/videoOutputPortConfig.cpp

+		{
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[1]);
+			ret = searchConfigs((void **)&configuration.pKVideoPortConfigs_size, (char *)searchVaribles[1]);
+			if(ret == false)


Do we need fallbacks here as well ?

We should not mix old and new configs.

yuvaramachandran-gurusamy · 2025-11-14T09:03:59Z

ds/videoOutputPortConfig.cpp

-		for (size_t i = 0; i < numResolutions; i++) {
-			dsVideoPortResolution_t *resolution = &kResolutions[i];
+		//size_t numResolutions = dsUTL_DIM(kResolutions);
+		for (size_t i = 0; i < *(configuration.pKResolutionsSettings_size); i++) {


Please add NULL check here as well.

yuvaramachandran-gurusamy · 2025-11-14T09:04:07Z

ds/videoOutputPortConfig.cpp

 		 */
-		for (size_t i = 0; i < dsUTL_DIM(kPorts); i++) {
-			const dsVideoPortPortConfig_t *port = &kPorts[i];
+		for (size_t i = 0; i < *(configuration.pKVideoPortPorts_size); i++) {


Please add NULL check here as well.

apatel859

fix review

Copilot

Pull Request Overview

This PR introduces dynamic configuration loading using dlsym() to load device settings configuration variables from a HAL library at runtime, replacing the previous static linking approach. This change adds flexibility by allowing configuration to be sourced from external libraries while maintaining backward compatibility through a fallback mechanism to static configurations.

Key Changes

Added searchConfigs() function in manager.cpp that uses dlopen()/dlsym() to dynamically load configuration symbols from the HAL library
Modified configuration loading in videoOutputPortConfig.cpp, videoDeviceConfig.cpp, frontPanelConfig.cpp, and audioOutputPortConfig.cpp to attempt dynamic loading first, falling back to static configs if unavailable
Introduced debug dump functions in each config file to log loaded configuration details for troubleshooting

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 22 comments.

Show a summary per file

File	Description
ds/manager.cpp	Implements `searchConfigs()` function for dynamic symbol lookup using dlsym() with mutex protection
ds/include/manager.hpp	Adds forward declaration for the `searchConfigs()` function
ds/videoOutputPortConfig.cpp	Updates video port configuration loading to use dynamic lookup with fallback, adds struct and debug dump function
ds/videoDeviceConfig.cpp	Updates video device configuration loading to use dynamic lookup with fallback, adds debug functionality
ds/frontPanelConfig.cpp	Updates front panel configuration loading to use dynamic lookup with fallback, adds debug dump function
ds/audioOutputPortConfig.cpp	Updates audio port configuration loading to use dynamic lookup with fallback, adds debug dump function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-14T15:32:04Z

ds/audioOutputPortConfig.cpp

+		if ( configuration.pKConfigs != NULL || configuration.pKPorts != NULL ||
+			configuration.pKConfigSize != NULL || configuration.pKPortSize != NULL) {


The condition uses OR (||) instead of AND (&&). This means the code inside the block will execute even if only ONE pointer is non-NULL, which could lead to null pointer dereferences when accessing the other pointers. All four pointers should be checked with AND logic to ensure they're all valid before use.

Suggested change

if ( configuration.pKConfigs != NULL || configuration.pKPorts != NULL ||

configuration.pKConfigSize != NULL || configuration.pKPortSize != NULL) {

if ( configuration.pKConfigs != NULL && configuration.pKPorts != NULL &&

configuration.pKConfigSize != NULL && configuration.pKPortSize != NULL) {

Copilot · 2025-11-14T15:32:04Z

ds/videoOutputPortConfig.cpp

 #include <string.h>
 using namespace std;

+#define DEBUG 1 // Using for dumpconfig 


The DEBUG macro is hardcoded to 1, which means debug code (including dumpconfig() calls) will always execute in production builds. This can impact performance and produce excessive logging.

Consider using a build-time configuration or removing the macro entirely if debug output is always desired, or setting it to 0 by default.

Suggested change

#define DEBUG 1 // Using for dumpconfig

#ifndef DEBUG

#define DEBUG 0

#endif // DEBUG

Copilot · 2025-11-14T15:32:05Z

ds/frontPanelConfig.cpp

+	int indicatorSize, indicatorColorSize, invalid_size = -1;
+	fpdConfigs_t configuration = {0};
+
+	const char* searchVaribles[] = {


The variable name searchVaribles is misspelled. It should be searchVariables.

Copilot · 2025-11-14T15:32:05Z

ds/frontPanelConfig.cpp

+	int indicatorSize, indicatorColorSize, invalid_size = -1;
+	fpdConfigs_t configuration = {0};
+
+	const char* searchVaribles[] = {
+        "kFPDIndicatorColors",
+        "kFPDIndicatorColors_size",
+        "kIndicators",
+        "kIndicators_size",
+		"kTextDisplays",
+		"kTextDisplays_size"
+    };
+	bool ret = false;
+
+		INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[0]);
+		ret = searchConfigs((void **)&configuration.pKFPDIndicatorColors, searchVaribles[0]);
+		if(ret == true)
+		{
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[1]);
+			ret = searchConfigs((void **)&configuration.pKFPDIndicatorColors_size, (char *)searchVaribles[1]);
+			if(ret == false)
+			{
+				INT_ERROR("%s is not defined\n", searchVaribles[1]);
+				configuration.pKFPDIndicatorColors_size = &invalid_size;
+			}
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[2]);
+			ret = searchConfigs((void **)&configuration.pKIndicators, searchVaribles[2]);
+			if(ret == false)
+			{
+				INT_ERROR("%s is not defined\n", searchVaribles[2]);
+			}
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[3]);
+			ret = searchConfigs((void **)&configuration.pKIndicators_size, (char *)searchVaribles[3]);
+			if(ret == false)
+			{
+				INT_ERROR("%s is not defined\n", searchVaribles[3]);
+				configuration.pKIndicators_size = &invalid_size;
+			}
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[4]);
+			ret = searchConfigs((void **)&configuration.pKTextDisplays, searchVaribles[4]);
+			if(ret == false)
+			{
+				INT_ERROR("%s is not defined\n", searchVaribles[4]);
+			}
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[5]);
+			ret = searchConfigs((void **)&configuration.pKTextDisplays_size, (char *)searchVaribles[5]);
+			if(ret == false)
+			{
+				INT_ERROR("%s is not defined\n", searchVaribles[5]);
+				configuration.pKTextDisplays_size = &invalid_size;
+			}
+		}
+		else
+		{
+			INT_ERROR("Read Old Configs\n");
+			configuration.pKFPDIndicatorColors = kIndicatorColors;
+			indicatorColorSize = dsUTL_DIM(kIndicatorColors);
+			configuration.pKFPDIndicatorColors_size = &indicatorColorSize;
+			configuration.pKIndicators = kIndicators;
+			indicatorSize = dsUTL_DIM(kIndicators);
+			configuration.pKIndicators_size = &indicatorSize;
+			configuration.pKTextDisplays = kTextDisplays;
+			indicatorSize = dsUTL_DIM(kTextDisplays);
+			configuration.pKTextDisplays_size = &indicatorSize;


Local stack variables indicatorSize, indicatorColorSize, and invalid_size may go out of scope while their addresses are still stored in the configuration struct and used later. When the fallback path is taken (lines 463-471) or when invalid_size is assigned (lines 431, 444, 457), these local variables' addresses are stored and later dereferenced throughout the function. This results in undefined behavior.

The variables should be declared as static or the configuration struct should store the values directly instead of pointers to local variables.

Copilot · 2025-11-14T15:32:05Z

ds/manager.cpp

+
+	pthread_mutex_lock(&dsLock);
+
+		void *dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);
+		if (dllib) {
+			*pConfigVar = (void *) dlsym(dllib, searchConfigStr);
+			if (*pConfigVar != NULL) {
+				INT_INFO("%s is defined and loaded  pConfigVar= %p\r\n", searchConfigStr, *pConfigVar);
+			}
+			else {
+				INT_ERROR("%d:%s: %s is not defined\n", __LINE__, __func__, searchConfigStr);
+			}
+
+			dlclose(dllib);
+		}
+		else {
+			INT_ERROR("%d:%s: Open %s failed\n", __LINE__, __func__, RDK_DSHAL_NAME);
+		}


The dlopen() handle is not stored and dlclose() is called immediately after dlsym(). This means the loaded library is unloaded while the returned pointers are still being used throughout the application lifecycle. When dlclose() is called, the memory pointed to by the symbols may become invalid, leading to potential crashes or undefined behavior.

Consider either:

Keeping the library handle open for the lifetime of the application (store it globally and never close it)

Using RTLD_NODELETE flag with dlopen() to prevent unloading

Suggested change

pthread_mutex_lock(&dsLock);

void *dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);

if (dllib) {

*pConfigVar = (void *) dlsym(dllib, searchConfigStr);

if (*pConfigVar != NULL) {

INT_INFO("%s is defined and loaded pConfigVar= %p\r\n", searchConfigStr, *pConfigVar);

}

else {

INT_ERROR("%d:%s: %s is not defined\n", __LINE__, __func__, searchConfigStr);

}

dlclose(dllib);

}

else {

INT_ERROR("%d:%s: Open %s failed\n", __LINE__, __func__, RDK_DSHAL_NAME);

}

static void *dllib = nullptr;

pthread_mutex_lock(&dsLock);

if (!dllib) {

dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY);

if (!dllib) {

INT_ERROR("%d:%s: Open %s failed\n", __LINE__, __func__, RDK_DSHAL_NAME);

pthread_mutex_unlock(&dsLock);

INT_INFO("%d:%s: Exit function\n", __LINE__, __func__);

return false;

}

}

*pConfigVar = (void *) dlsym(dllib, searchConfigStr);

if (*pConfigVar != NULL) {

INT_INFO("%s is defined and loaded pConfigVar= %p\r\n", searchConfigStr, *pConfigVar);

}

else {

INT_ERROR("%d:%s: %s is not defined\n", __LINE__, __func__, searchConfigStr);

}

// Do NOT dlclose(dllib); keep the handle open for the lifetime of the process

Need to check with team

Copilot · 2025-11-14T15:32:09Z

ds/videoDeviceConfig.cpp

 {
+	int configSize, invalid_size = -1;
+	videoDeviceConfig_t videoDeviceConfig = {0};
+	const char* searchVaribles[] = {


The variable name searchVaribles is misspelled. It should be searchVariables.

Copilot · 2025-11-14T15:32:09Z

ds/videoDeviceConfig.cpp

+
+

Trailing whitespace at the end of the line should be removed.

Suggested change

Copilot · 2025-11-14T15:32:09Z

ds/frontPanelConfig.cpp

 #include "dslogger.h"
+#include "manager.hpp"
+
+#define DEBUG 1 // Using for dumpconfig 


The DEBUG macro is hardcoded to 1, which means debug code will always execute in production builds. This can impact performance and produce excessive logging.

Consider using a build-time configuration or removing the macro entirely if debug output is always desired, or setting it to 0 by default.

Suggested change

#define DEBUG 1 // Using for dumpconfig

#ifndef DEBUG

#define DEBUG 0

#endif

Copilot · 2025-11-14T15:32:10Z

ds/audioOutputPortConfig.cpp

 {
+	int configSize, portSize;
+	audioConfigs_t configuration = {0};
+	const char* searchVaribles[] = {


The variable name searchVaribles is misspelled. It should be searchVariables.

Suggested change

const char* searchVaribles[] = {

const char* searchVariables[] = {

Copilot · 2025-11-14T15:32:10Z

ds/audioOutputPortConfig.cpp

+			configuration.pKConfigs = kConfigs;
+			configSize = dsUTL_DIM(kConfigs);
+			configuration.pKConfigSize = &configSize;
+			configuration.pKPorts = kPorts;


Local stack variables configSize and portSize may go out of scope while their addresses are still stored in the configuration struct and used later. When the fallback path is taken (lines 226-231), these local variables' addresses are stored and later dereferenced at lines 247 and 268. This results in undefined behavior.

The variables should be declared as static or the configuration struct should store the values directly instead of pointers to local variables.

Suggested change

configuration.pKConfigs = kConfigs;

configSize = dsUTL_DIM(kConfigs);

configuration.pKConfigSize = &configSize;

configuration.pKPorts = kPorts;

configuration.pKConfigs = kConfigs;

static int configSize;

configSize = dsUTL_DIM(kConfigs);

configuration.pKConfigSize = &configSize;

configuration.pKPorts = kPorts;

static int portSize;

Added the static in the start of funcation and using same here.

apatel859 · 2025-11-14T15:38:48Z

ds/audioOutputPortConfig.cpp

+		if(ret == true)
+		{
+			INT_INFO("%d:%s: Calling  searchConfigs( %s)\n", __LINE__, __func__, searchVaribles[2]);
+			ret = searchConfigs((void **)&configuration.pKConfigSize, (char *)searchVaribles[2]);


When u call searchConfig API first it should have input variable and second out variable. it means earchVaribles[2] should be first argumenet not second

apatel859 · 2025-11-14T15:39:25Z

ds/audioOutputPortConfig.cpp

-			_aPortTypes.at(port->id.type).addPort(_aPorts.at(i));
-		}
+		if ( configuration.pKConfigs != NULL || configuration.pKPorts != NULL ||
+			configuration.pKConfigSize != NULL || configuration.pKPortSize != NULL) {


all four should be there so u should use &&

apatel859

as code is common apply this to all file and will re review next week

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-17T07:36:18Z

ds/videoOutputPortConfig.cpp

 		/* Initialize a set of supported resolutions
 		 *
 		 */
-		size_t numResolutions = dsUTL_DIM(kResolutions);


Coverity Issue - Dereference after null check

Passing "&configuration" to "dumpconfig", which dereferences null "configuration.pKVideoPortConfigs_size".

Medium Impact, CWE-476
FORWARD_NULL

We are validated the all structure pointers then calling dumpconfig().

rdkcmf-jenkins · 2025-11-17T07:36:18Z

ds/frontPanelConfig.cpp

 		 * Create TextDisplays
 		 * 1. Use Supported Colors created for indicators.
 		 * 2. Create Text Displays.
 		 */


Coverity Issue - Dereference before null check

Null-checking "configuration.pKTextDisplays_size" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

rdkcmf-jenkins · 2025-11-17T07:36:18Z

ds/videoOutputPortConfig.cpp

 		/* Initialize a set of supported resolutions
 		 *
 		 */
-		size_t numResolutions = dsUTL_DIM(kResolutions);


Coverity Issue - Dereference after null check

Passing "&configuration" to "dumpconfig", which dereferences null "configuration.pKResolutionsSettings_size".

Medium Impact, CWE-476
FORWARD_NULL

rdkcmf-jenkins · 2025-11-17T07:36:18Z

ds/videoOutputPortConfig.cpp

 		/* Initialize a set of supported resolutions
 		 *
 		 */
-		size_t numResolutions = dsUTL_DIM(kResolutions);


Coverity Issue - Dereference after null check

Passing "&configuration" to "dumpconfig", which dereferences null "configuration.pKVideoPortPorts_size".

Medium Impact, CWE-476
FORWARD_NULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-17T10:28:43Z

ds/frontPanelConfig.cpp

 		 * Create TextDisplays
 		 * 1. Use Supported Colors created for indicators.
 		 * 2. Create Text Displays.
 		 */


Coverity Issue - Dereference before null check

Null-checking "configuration.pKTextDisplays_size" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-17T13:01:36Z

ds/frontPanelConfig.cpp

 		 * Create TextDisplays
 		 * 1. Use Supported Colors created for indicators.
 		 * 2. Create Text Displays.
 		 */


Coverity Issue - Dereference before null check

Null-checking "configuration.pKTextDisplays_size" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-20T06:53:14Z

ds/frontPanelConfig.cpp

+			INT_INFO("  Text Display ID: %d, Max Brightness: %d, Max Cycle Rate: %d, Levels: %d, Max Horizontal Iterations: %d, Max Vertical Iterations: %d, Supported Characters: %s, Color Mode: %d\n",
+				   configuration->pKTextDisplays[i].id,
+			   	configuration->pKTextDisplays[i].maxBrightness,
+			   	configuration->pKTextDisplays[i].maxCycleRate,


Coverity Issue - Dereference before null check

Null-checking "configuration->pKTextDisplays_size" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

rdkcmf-jenkins · 2025-11-20T06:53:14Z

ds/frontPanelConfig.cpp

+		 	* Create TextDisplays
+		 	* 1. Use Supported Colors created for indicators.
+		 	* 2. Create Text Displays.
+		 	*/


Coverity Issue - Dereference before null check

Null-checking "configuration.pKTextDisplays_size" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-11-20T07:22:02Z

ds/frontPanelConfig.cpp

+				   configuration->pKTextDisplays[i].id,
+			   	configuration->pKTextDisplays[i].maxBrightness,
+			   	configuration->pKTextDisplays[i].maxCycleRate,
+			   	configuration->pKTextDisplays[i].levels,


Coverity Issue - Dereference after null check

Dereferencing null pointer "configuration->pKTextDisplays_size".

Medium Impact, CWE-476
FORWARD_NULL

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

sync to develop

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-12-10T11:43:47Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/devicesettings/168/rdk/components/generic/devicesettings
Commit: dde8258

Report detail: gist'

RDKEMW-8587: consume the config variables using dlsym() in MW.

1374c07

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

santoshcomcast requested a review from a team as a code owner October 30, 2025 12:00

santoshcomcast added 2 commits October 30, 2025 12:15

fix build issue

6b95abb

fix build issue

2f17837

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

apatel859 reviewed Nov 3, 2025

View reviewed changes

ds/audioOutputPortConfig.cpp Outdated Show resolved Hide resolved

santoshcomcast added 5 commits November 5, 2025 07:58

addressed review comments

2e068a5

fix build issue

6fd6b4f

fix build issue

9932c3c

fix build issue

cc2121a

fix build issue

0d13c48

rdkcmf-jenkins reviewed Nov 5, 2025

View reviewed changes

fix build issue

397cf75

santoshcomcast commented Nov 5, 2025

View reviewed changes

rdkcmf-jenkins reviewed Nov 5, 2025

View reviewed changes

santoshcomcast added 2 commits November 5, 2025 13:26

fix coverity issue and removed unwanted code.

8433557

Fix build issue.

51c8af5

rdkcentral deleted a comment from rdkcmf-jenkins Nov 6, 2025

santoshcomcast added 4 commits November 6, 2025 11:47

Addressed review comments.

020d7fc

Addressed review comments.

7e8a9f4

addressed review comments.

b1e9412

RDKEMW-8587: consume the config variables using dlsym() in MW.

661e8ec

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 11, 2025

View reviewed changes

santoshcomcast added 2 commits November 12, 2025 10:46

RDKEMW-8587: consume the config variables using dlsym() in MW.

bbe42f2

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

fix build issue

299bf52

rdkcmf-jenkins reviewed Nov 12, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

5f5a634

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 13, 2025

View reviewed changes

yuvaramachandran-gurusamy reviewed Nov 14, 2025

View reviewed changes

apatel859 requested changes Nov 14, 2025

View reviewed changes

Copilot AI reviewed Nov 14, 2025

View reviewed changes

apatel859 reviewed Nov 14, 2025

View reviewed changes

apatel859 requested changes Nov 14, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

12f0193

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 17, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

565dbde

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 17, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

17faa45

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 17, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

8f60d7e

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 20, 2025

View reviewed changes

RDKEMW-8587: consume the config variables using dlsym() in MW.

7455db3

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Nov 20, 2025

View reviewed changes

santoshcomcast and others added 7 commits November 20, 2025 07:32

RDKEMW-8587: consume the config variables using dlsym() in MW.

8e51e51

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Merge pull request #179 from rdkcentral/develop

329c312

sync to develop

debug. disable dumpconfig and add logs

1928496

enable debugconfig

05aa70f

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

move the debug prints within if condtion for all config dumpconfig

64a4609

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

added few more logs, lock_guard in searchconfig

9789231

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

add delay while every load

dde8258

santoshcomcast and others added 7 commits December 11, 2025 10:15

add count variable for close the opened hal file

edb8f55

fix build issue.

2864e49

add condition wait for 4 loads complete.

e287d3a

disable the dlclose.

bccfc77

Force to use FP old config to check crash.

103ec2a

fix fp Update frontPanelConfig.cpp

76d0910

fix build error

acd9e70

		if ( configuration.pKConfigs != NULL \|\| configuration.pKPorts != NULL \|\|
		configuration.pKConfigSize != NULL \|\| configuration.pKPortSize != NULL) {

-#define DEBUG 1 // Using for dumpconfig
+#ifndef DEBUG
+#define DEBUG 0
+#endif // DEBUG

	const char* searchVaribles[] = {
	const char* searchVariables[] = {

RDKEMW-8587: consume the config variables using dlsym() in MW. #168

Are you sure you want to change the base?

RDKEMW-8587: consume the config variables using dlsym() in MW. #168

Uh oh!

Conversation

santoshcomcast commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santoshcomcast Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Explicit null dereferenced

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

Uh oh!

santoshcomcast left a comment

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Out-of-bounds access

Uh oh!

rdkcmf-jenkins Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Explicit null dereferenced

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Explicit null dereferenced

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

rdkcmf-jenkins Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

rdkcmf-jenkins Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Invalid type in argument to printf format specifier

Uh oh!

santoshcomcast Nov 5, 2025 •

edited

Loading

rdkcmf-jenkins Nov 5, 2025 •

edited

Loading

rdkcmf-jenkins Nov 5, 2025 •

edited

Loading

rdkcmf-jenkins Nov 5, 2025 •

edited

Loading

rdkcmf-jenkins Nov 5, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 11, 2025 •

edited

Loading

rdkcmf-jenkins Nov 12, 2025 •

edited

Loading

rdkcmf-jenkins Nov 12, 2025 •

edited

Loading

rdkcmf-jenkins Nov 12, 2025 •

edited

Loading

rdkcmf-jenkins Nov 12, 2025 •

edited

Loading

rdkcmf-jenkins Nov 12, 2025 •

edited

Loading

rdkcmf-jenkins Nov 13, 2025 •

edited

Loading

rdkcmf-jenkins Nov 13, 2025 •

edited

Loading

rdkcmf-jenkins Nov 13, 2025 •

edited

Loading

rdkcmf-jenkins Nov 13, 2025 •

edited

Loading

rdkcmf-jenkins Nov 13, 2025 •

edited

Loading