RDKEMW-8587: consume the config variables using dlsym() in MW #185

yuvaramachandran-gurusamy · 2025-12-11T14:56:18Z

RDKEMW-8587: consume the config variables using dlsym() in MW.

Reason for change: consume the config variables using dlsym() in MW.
Test Procedure: refer RDKEMW-8587
Risks: High
Signed-off-by:gsanto722 grandhi_santoshkumar@comcast.com

ds/videoDeviceConfig.cpp

ds/videoOutputPortConfig.cpp

ds/audioOutputPortConfig.cpp

ds/videoOutputPortConfig.cpp

apatel859 · 2025-12-13T06:21:22Z

ds/frontPanelConfig.cpp

+    int indicatorColorSize = -1;
+    int textDisplaySize = (configuration->pKTextDisplays_size) ? *(configuration->pKTextDisplays_size) : -1;
+    // Dump the configuration details
+    INT_INFO("\n\n===========================================================================\n\n");


this two line be comboned like

INT_INFO("\n===========Starting to Dump FrontPanel Configs=======\n");

apatel859 · 2025-12-13T06:22:02Z

ds/frontPanelConfig.cpp

 #include "dslogger.h"
+#include "manager.hpp"
+
+#define DEBUG 1 // Using for dumpconfig 


if you already have access("/opt/dsMgrDumpDeviceConfigs", chec kwhy we need DEBUG 1?

apatel859 · 2025-12-13T06:24:49Z

ds/videoOutputPortConfig.cpp

+            INT_INFO("resolution->interlaced= %d", resolution->interlaced);
+        }
+        INT_INFO("\n\n####################################################################### \n\n");
+        INT_INFO("\n\n####################################################################### \n\n");


reduce unnecessary logs every where

apatel859

i see excess logs can u reduce as commented in all placeses

Copilot

Pull request overview

This PR implements dynamic configuration loading using dlsym() for the device settings middleware layer, enabling runtime loading of device capabilities from shared libraries instead of static compile-time configuration.

Key Changes:

Introduced loadDeviceCapabilities() function in manager.cpp that uses dlsym() to dynamically load configuration symbols from RDK_DSHAL_NAME library
Modified load() methods across all config classes (Audio/Video/FrontPanel) to accept configuration structure pointers, supporting both dynamic and static configurations
Enhanced logging infrastructure by adding function name to log macros and replacing printf statements with INT_INFO/INT_ERROR for consistency
Added dumpconfig() functions for debugging configuration data when /opt/dsMgrDumpDeviceConfigs file exists

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 25 comments.

Show a summary per file

File	Description
ds/videoOutputPortConfig.hpp	Added videoPortConfigs_t struct and modified load() signature to accept config pointer
ds/videoOutputPortConfig.cpp	Implemented dynamic config loading with fallback to static, added dumpconfig() function, converted printf to INT_INFO
ds/videoDeviceConfig.hpp	Added videoDeviceConfig_t struct and modified load() signature
ds/videoDeviceConfig.cpp	Implemented dynamic config loading with fallback to static, added dumpconfig() function
ds/audioOutputPortConfig.hpp	Added audioConfigs_t struct and modified load() signature
ds/audioOutputPortConfig.cpp	Implemented dynamic config loading with fallback to static, added dumpconfig() function
ds/frontPanelConfig.hpp	Added fpdConfigs_t struct, moved load() to public, added m_isFPConfigLoaded flag
ds/frontPanelConfig.cpp	Implemented dynamic config loading, removed automatic load() call from getInstance(), added dumpconfig()
ds/manager.cpp	Added LoadDLSymbols() and loadDeviceCapabilities() functions, integrated dynamic loading into Initialize() and load()
ds/include/manager.hpp	Added DeviceCapabilityTypes enum, dlSymbolLookup struct, function declarations
ds/include/dslogger.h	Changed LogLevel to enum, added function parameter to ds_log() signature
ds/dslogger.cpp	Enhanced logging with thread ID, function name, and improved formatting
ds/videoOutputPort.cpp	Code formatting changes (indentation) and printf to INT_INFO conversion
ds/host.cpp	Converted printf to INT_INFO
ds/hdmiIn.cpp	Converted printf to INT_INFO throughout
ds/frontPanelIndicator.cpp	Removed empty lines (formatting only)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T06:42:17Z

ds/videoDeviceConfig.cpp

 #include "dslogger.h"
+#include "manager.hpp"

+#define DEBUG 1 // Using for dumpconfig 


The 'DEBUG' macro is defined but never used in this file. If it's intended to control the dumpconfig functionality, it should be checked before calling dumpconfig(), or removed if unnecessary. Consider removing it to avoid confusion.

Suggested change

#define DEBUG 1 // Using for dumpconfig

Copilot · 2025-12-13T06:42:18Z

ds/include/manager.hpp

 	static void DeInitialize();
    static void load(); //!< This function is being used for loading configure in-process DSMgr.
-	static int IsInitialized;   //!< Indicates the application has initialized with devicettings modules.
+    static int IsInitialized;   //!< Indicates the application has initialized with devicettings modules.


The comment references 'devicettings' which appears to be a typo for 'device settings'. This typo exists in the original code but should be corrected for clarity.

Suggested change

static int IsInitialized; //!< Indicates the application has initialized with devicettings modules.

static int IsInitialized; //!< Indicates the application has initialized with Device Settings modules.

Copilot · 2025-12-13T06:42:18Z

ds/manager.cpp

 	{std::lock_guard<std::mutex> lock(gManagerInitMutex);
-	printf("Entering %s count %d with thread id %lu\n",__FUNCTION__,IsInitialized,pthread_self());
+
+	INT_INFO("Entering ... count %d with thread id %lu\n",IsInitialized,pthread_self());


The format string at line 230 has an unnecessary '\n' character. The INT_INFO macro already handles line termination as shown in dslogger.cpp line 66-72 where '\n' is added. Remove the '\n' from the format string for consistency.

Suggested change

INT_INFO("Entering ... count %d with thread id %lu\n",IsInitialized,pthread_self());

INT_INFO("Entering ... count %d with thread id %lu",IsInitialized,pthread_self());

Copilot · 2025-12-13T06:42:18Z

ds/frontPanelConfig.cpp

+    }
+    else
+    {
+        INT_ERROR("No valid text display configuration found\n");


The INT_ERROR message at line 507 ends with '\n', but the INT_ERROR macro already adds a newline. This results in extra blank lines in the log output. Remove the '\n' from the format string.

Suggested change

INT_ERROR("No valid text display configuration found\n");

INT_ERROR("No valid text display configuration found");

Copilot · 2025-12-13T06:42:19Z

ds/frontPanelConfig.cpp

+    if (( false == m_isFPInitialized) || (true == m_isFPConfigLoaded)) {
+        INT_ERROR("'%s'", (!m_isFPInitialized) ? "Front Panel not initialized" : "Front Panel Config already loaded");


The function returns early at line 427 if config is already loaded or if FP is not initialized, but the check should ensure that if FP is not initialized, it should return an error or throw an exception. The current logic with return statement may silently fail without notifying the caller of the configuration load failure. Consider throwing an exception instead of returning silently.

Suggested change

if (( false == m_isFPInitialized) || (true == m_isFPConfigLoaded)) {

INT_ERROR("'%s'", (!m_isFPInitialized) ? "Front Panel not initialized" : "Front Panel Config already loaded");

if (!m_isFPInitialized) {

INT_ERROR("'Front Panel not initialized'");

throw IllegalArgumentException("Front Panel not initialized");

}

if (m_isFPConfigLoaded) {

INT_ERROR("'Front Panel Config already loaded'");

Copilot · 2025-12-13T06:42:23Z

ds/frontPanelConfig.cpp

                _singleton.m_isFPInitialized = true;
                INT_INFO("dsFPInit success\n");


The load() function is being called with nullptr when symbols are not loaded. However, the frontend panel initialization in FrontPanelConfig::getInstance() (line 97-100) was previously calling load() automatically, which has been removed. Now load() needs to be called explicitly with proper error handling. If the load fails or isn't called, the config won't be initialized, but m_isFPInitialized will still be set to true, leading to an inconsistent state.

Suggested change

_singleton.m_isFPInitialized = true;

INT_INFO("dsFPInit success\n");

// Attempt to load the front panel configuration

if (_singleton.load())

{

_singleton.m_isFPInitialized = true;

INT_INFO("dsFPInit and config load success\n");

}

else

{

INT_ERROR("dsFPInit succeeded but config load failed\n");

}

Moved the load() to Manager::Initialize().

Copilot · 2025-12-13T06:42:23Z

ds/audioOutputPortConfig.cpp

+            configuration.pKConfigs = kConfigs;
+            configSize = dsUTL_DIM(kConfigs);
+            configuration.pKConfigSize = &configSize;
+            configuration.pKPorts = kPorts;
+            portSize = dsUTL_DIM(kPorts);
+            configuration.pKPortSize = &portSize;


Similar to the issue in videoOutputPortConfig.cpp, the size pointers in the configuration structure point to local stack variables ('configSize', 'portSize'). These local variables will go out of scope when the function returns, making the pointers invalid. This could lead to undefined behavior if the configuration structure is accessed after function completion.

Copilot · 2025-12-13T06:42:23Z

ds/frontPanelConfig.cpp

+        configuration.pKFPDIndicatorColors = kIndicatorColors;
+        indicatorColorSize = dsUTL_DIM(kIndicatorColors);
+        configuration.pKFPDIndicatorColors_size = &indicatorColorSize;
+        configuration.pKIndicators = kIndicators;
+        indicatorSize = dsUTL_DIM(kIndicators);
+        configuration.pKIndicators_size = &indicatorSize;
+        configuration.pKTextDisplays = kTextDisplays;
+        textDisplaySize = dsUTL_DIM(kTextDisplays);
+        configuration.pKTextDisplays_size = &textDisplaySize;


Similar to the issue in other config files, the size pointers in the configuration structure point to local stack variables ('indicatorColorSize', 'indicatorSize', 'textDisplaySize'). These local variables will go out of scope when the function returns, making the pointers invalid. This could lead to undefined behavior if the configuration structure is accessed after function completion.

Copilot · 2025-12-13T06:42:24Z

ds/frontPanelConfig.cpp

+        int indicatorSize = (configuration->pKIndicators_size) ? *(configuration->pKIndicators_size) : -1;
+        int indicatorColorSize = (configuration->pKFPDIndicatorColors_size) ? *(configuration->pKFPDIndicatorColors_size) : -1;


The variable 'indicatorColorSize' is declared twice - once at line 355 with initialization to -1, and again at line 363 inside the if block where it's reassigned. The first declaration is shadowed by the second, making the initial assignment ineffective. Remove the second declaration at line 362 to avoid shadowing.

Suggested change

int indicatorSize = (configuration->pKIndicators_size) ? *(configuration->pKIndicators_size) : -1;

int indicatorColorSize = (configuration->pKFPDIndicatorColors_size) ? *(configuration->pKFPDIndicatorColors_size) : -1;

indicatorSize = (configuration->pKIndicators_size) ? *(configuration->pKIndicators_size) : -1;

indicatorColorSize = (configuration->pKFPDIndicatorColors_size) ? *(configuration->pKFPDIndicatorColors_size) : -1;

Copilot · 2025-12-13T06:42:24Z

ds/videoOutputPortConfig.cpp

+#define DEBUG 1 // Using for dumpconfig 
+


The 'DEBUG' macro is defined but never used in this file. If it's intended to control the dumpconfig functionality, it should be checked before calling dumpconfig(), or removed if unnecessary. Consider removing it to avoid confusion.

Suggested change

#define DEBUG 1 // Using for dumpconfig

apatel859 · 2025-12-15T16:18:25Z

ds/frontPanelConfig.cpp

+                fpdTextDisplayCfg->levels,
+                fpdTextDisplayCfg->maxHorizontalIterations,
+                fpdTextDisplayCfg->maxVerticalIterations,
+                (fpdTextDisplayCfg->supportedCharacters) ? fpdTextDisplayCfg->supportedCharacters : "NULL",


instead of NULL use macro that u have defined for "ABCDxxxx"

apatel859

fix it

apatel859 · 2025-12-15T16:21:32Z

ds/manager.cpp

-	device::VideoDeviceConfig::getInstance().load();
-	printf("%d:%s load completed\n", __LINE__, __FUNCTION__);
+    INT_INFO("Enter function");
+	loadDeviceCapabilities( device::DEVICE_CAPABILITY_VIDEO_PORT | 


why not DEVICE_CAPABILITY_FRONT_PANEL here

@apatel859 , This manager::load() called only from dsMgr context. And FrontPanel libds controlled from FrontPanel plugin. So we dont need FrontPanel config load here

Updated the DEVICE_CAPABILITY_FRONT_PANEL to use in dsmgr context.

yuvaramachandran-gurusamy · 2025-12-16T12:01:46Z

ds/audioOutputPortConfig.cpp

-	}
+void AudioOutputPortConfig::load(audioConfigs_t* dynamicAudioConfigs)
+{
+    static int configSize = -1, portSize = -1;


We dont need static variables here

yuvaramachandran-gurusamy · 2025-12-16T12:02:56Z

ds/frontPanelConfig.cpp

+    * 1. Create Supported Colors.
+    * 2. Create Indicators.
+    */
+    static int indicatorSize, indicatorColorSize, textDisplaySize;


We dont need static variables here

yuvaramachandran-gurusamy · 2025-12-16T12:03:18Z

ds/videoDeviceConfig.cpp

 #include "dslogger.h"
+#include "manager.hpp"

+#define DEBUG 1 // Using for dumpconfig 


Can we remove this

yuvaramachandran-gurusamy · 2025-12-16T12:03:28Z

ds/videoDeviceConfig.cpp

+
+void VideoDeviceConfig::load(videoDeviceConfig_t* dynamicVideoDeviceConfigs)
+{
+	static int configSize = -1;


We dont need static variables here

yuvaramachandran-gurusamy · 2025-12-16T12:03:54Z

ds/videoOutputPortConfig.cpp

 #include <string.h>
 using namespace std;

+#define DEBUG 1 // Using for dumpconfig 


Can we remove this

yuvaramachandran-gurusamy · 2025-12-16T12:07:10Z

ds/manager.cpp

+	loadDeviceCapabilities( device::DEVICE_CAPABILITY_VIDEO_PORT | 
+                            device::DEVICE_CAPABILITY_AUDIO_PORT |
+                            device::DEVICE_CAPABILITY_VIDEO_DEVICE |
+                            device::DEVICE_CAPABILITY_FRONT_PANEL);


@santoshcomcast , Can we remove FrontPanel here once @apatel859 agreed based on comments as above

yuvaramachandran-gurusamy · 2025-12-16T12:10:45Z

ds/include/frontPanelConfig.hpp

+    /* Terminate Front Panel */
+    void fPTerm();

+    void load(fpdConfigs_t* pDLHandle);


Can we rename pDLHandle into dynamicConfigPtr or something

yuvaramachandran-gurusamy · 2025-12-16T12:10:59Z

ds/audioOutputPortConfig.hpp

 	List<AudioOutputPortType> 	 getSupportedTypes();

-	void load();
+	void load(audioConfigs_t* pDLHandle);


Can we rename pDLHandle into dynamicConfigPtr or something

yuvaramachandran-gurusamy · 2025-12-16T12:11:09Z

ds/videoDeviceConfig.hpp

 	VideoDFC & getDefaultDFC();

-	void load();
+	void load(videoDeviceConfig_t* pDLHandle);


Can we rename pDLHandle into dynamicConfigPtr or something

yuvaramachandran-gurusamy · 2025-12-16T12:11:20Z

ds/videoOutputPortConfig.hpp

 	List<VideoResolution> getSupportedResolutions(bool isIgnoreEdid=false);

-	void load();
+	void load(videoPortConfigs_t* pDLHandle);


Can we rename pDLHandle into dynamicConfigPtr or something

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

…logging format Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Reason for change: Address review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

Reason for change: Addressed review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

yuvaramachandran-gurusamy requested a review from a team as a code owner December 11, 2025 14:56

rdkcmf-jenkins reviewed Dec 12, 2025

View reviewed changes

yuvaramachandran-gurusamy requested a review from rdkcmf-jenkins December 12, 2025 22:59

apatel859 reviewed Dec 13, 2025

View reviewed changes

apatel859 requested changes Dec 13, 2025

View reviewed changes

apatel859 requested a review from Copilot December 13, 2025 06:35

Copilot started reviewing on behalf of apatel859 December 13, 2025 06:36 View session

Copilot AI reviewed Dec 13, 2025

View reviewed changes

apatel859 reviewed Dec 15, 2025

View reviewed changes

apatel859 requested changes Dec 15, 2025

View reviewed changes

apatel859 reviewed Dec 15, 2025

View reviewed changes

yuvaramachandran-gurusamy commented Dec 16, 2025

View reviewed changes

santoshcomcast added 16 commits January 6, 2026 10:48

RDKEMW-8587: consume the config variables using dlsym() in MW.

6abd424

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

fix build issue

59bbd5c

fix build issue

b08a24d

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

addressed review comments

9cc6b5f

fix build issue

ade5a61

fix build issue

6ac6e50

fix build issue

2dc944b

fix build issue

f6f3d48

fix build issue

441361b

fix coverity issue and removed unwanted code.

8d36de9

Fix build issue.

c676229

Addressed review comments.

968901d

Addressed review comments.

513b3c7

addressed review comments.

fb4785d

RDKEMW-8587: consume the config variables using dlsym() in MW.

35661b4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

4c52eeb

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

santoshcomcast and others added 22 commits January 6, 2026 10:48

fix build issue

e645685

RDKEMW-8587: consume the config variables using dlsym() in MW.

db4fa61

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

f5838f4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

82e1bf4

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

2ee6669

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

f68259b

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

45e0530

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

43ad5ad

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

de32c1b

Reason for change: consume the config variables using dlsym() in MW. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

debug. disable dumpconfig and add logs

efe2f43

enable debugconfig

a84c6eb

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

move the debug prints within if condtion for all config dumpconfig

2b96a08

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

added few more logs, lock_guard in searchconfig

703701e

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

add delay while every load

0ba55bf

RDKEMW-8587: Fix dl symbol crash issue

b69cb63

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix dl symbol crash issue

0b96ee2

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix dl symbol crash issue

32d57fb

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix build error

7ae4eb6

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fix FPD std::logical_error crash issue and enhanced the …

cca3783

…logging format Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: Fixed the coverity issues

01776ad

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

17564c6

Reason for change: Address review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

RDKEMW-8587: consume the config variables using dlsym() in MW.

b8cdf99

Reason for change: Addressed review comments. Test Procedure: refer RDKEMW-8587 Risks: High Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

santoshcomcast force-pushed the feature/RDKEMW-8587-dlsym branch from ef2294f to b8cdf99 Compare January 6, 2026 05:18

	static int IsInitialized; //!< Indicates the application has initialized with devicettings modules.
	static int IsInitialized; //!< Indicates the application has initialized with Device Settings modules.

	INT_INFO("Entering ... count %d with thread id %lu\n",IsInitialized,pthread_self());
	INT_INFO("Entering ... count %d with thread id %lu",IsInitialized,pthread_self());

	INT_ERROR("No valid text display configuration found\n");
	INT_ERROR("No valid text display configuration found");

		if (( false == m_isFPInitialized) \|\| (true == m_isFPConfigLoaded)) {
		INT_ERROR("'%s'", (!m_isFPInitialized) ? "Front Panel not initialized" : "Front Panel Config already loaded");

-    if (( false == m_isFPInitialized) || (true == m_isFPConfigLoaded)) {
-        INT_ERROR("'%s'", (!m_isFPInitialized) ? "Front Panel not initialized" : "Front Panel Config already loaded");
+    if (!m_isFPInitialized) {
+        INT_ERROR("'Front Panel not initialized'");
+        throw IllegalArgumentException("Front Panel not initialized");
+    }
+    if (m_isFPConfigLoaded) {
+        INT_ERROR("'Front Panel Config already loaded'");

		_singleton.m_isFPInitialized = true;
		INT_INFO("dsFPInit success\n");

-                _singleton.m_isFPInitialized = true;
-                INT_INFO("dsFPInit success\n");
+                // Attempt to load the front panel configuration
+                if (_singleton.load())
+                {
+                    _singleton.m_isFPInitialized = true;
+                    INT_INFO("dsFPInit and config load success\n");
+                }
+                else
+                {
+                    INT_ERROR("dsFPInit succeeded but config load failed\n");
+                }

		int indicatorSize = (configuration->pKIndicators_size) ? *(configuration->pKIndicators_size) : -1;
		int indicatorColorSize = (configuration->pKFPDIndicatorColors_size) ? *(configuration->pKFPDIndicatorColors_size) : -1;

RDKEMW-8587: consume the config variables using dlsym() in MW #185

Are you sure you want to change the base?

RDKEMW-8587: consume the config variables using dlsym() in MW #185

Uh oh!

Conversation

yuvaramachandran-gurusamy commented Dec 11, 2025 • edited by santoshcomcast Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apatel859 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apatel859 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

yuvaramachandran-gurusamy commented Dec 11, 2025 •

edited by santoshcomcast

Loading