-
Notifications
You must be signed in to change notification settings - Fork 4
RDKEMW-6339: No Audio when TV connected to speakers via SPDIF #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: apatel859 <Amit_Patel5@comcast.com>
| uint32_t audioDelay = dsGetAudioDelayInternal(_APortType); | ||
| dsSetAudioDelayInternal(param->handle,audioDelay); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Out-of-bounds write
Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).
High Impact, CWE-119
OVERRUN
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Out-of-bounds read
Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).
High Impact, CWE-125
OVERRUN
| returnAudioDelayMs = std::stoul(audioDelayMs); | ||
| } | ||
| catch(...) { | ||
| INT_INFO("%s: Exception in getting the audio delay from persistence storage, returning default value 0\n", __FUNCTION__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Invalid type in argument to printf format specifier
Argument "audioDelayMs" to format specifier "%d" was expected to have type "int" but has type "std::__cxx11::basic_string<char, std::char_traits, std::allocator >".
Medium Impact, CWE-686
PRINTF_ARGS
| } | ||
| else | ||
| { | ||
| INT_INFO("%s: (SERVER) Unable to set audiodelay as port is not enabled: %d \n", __FUNCTION__,m_AudioPortEnabled[_APortType]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Out-of-bounds read
Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).
High Impact, CWE-125
OVERRUN
| std::string _AudioDelay = std::to_string(param->audioDelayMs); | ||
| dsAudioPortType_t _APortType = _GetAudioPortType(param->handle); | ||
| switch(_APortType) { | ||
| case dsAUDIOPORT_TYPE_SPDIF: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverity Issue - Out-of-bounds read
Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).
High Impact, CWE-125
OVERRUN
RDKEMW-6339: No Audio when TV connected to speakers via SPDIF port
Signed-off-by: apatel859 Amit_Patel5@comcast.com