Skip to content

Conversation

@yuvaramachandran-gurusamy
Copy link
Contributor

RDKEMW-6339: No Audio when TV connected to speakers via SPDIF port

Signed-off-by: apatel859 Amit_Patel5@comcast.com

Signed-off-by: apatel859 <Amit_Patel5@comcast.com>
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner July 28, 2025 14:28
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team July 28, 2025 14:28
uint32_t audioDelay = dsGetAudioDelayInternal(_APortType);
dsSetAudioDelayInternal(param->handle,audioDelay);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Out-of-bounds write

Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).

High Impact, CWE-119
OVERRUN

}

}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Out-of-bounds read

Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).

High Impact, CWE-125
OVERRUN

returnAudioDelayMs = std::stoul(audioDelayMs);
}
catch(...) {
INT_INFO("%s: Exception in getting the audio delay from persistence storage, returning default value 0\n", __FUNCTION__);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Invalid type in argument to printf format specifier

Argument "audioDelayMs" to format specifier "%d" was expected to have type "int" but has type "std::__cxx11::basic_string<char, std::char_traits, std::allocator >".

Medium Impact, CWE-686
PRINTF_ARGS

}
else
{
INT_INFO("%s: (SERVER) Unable to set audiodelay as port is not enabled: %d \n", __FUNCTION__,m_AudioPortEnabled[_APortType]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Out-of-bounds read

Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).

High Impact, CWE-125
OVERRUN

std::string _AudioDelay = std::to_string(param->audioDelayMs);
dsAudioPortType_t _APortType = _GetAudioPortType(param->handle);
switch(_APortType) {
case dsAUDIOPORT_TYPE_SPDIF:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Out-of-bounds read

Overrunning array "m_AudioPortEnabled" of 6 bytes at byte offset 6 using index "_APortType" (which evaluates to 6).

High Impact, CWE-125
OVERRUN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants