RDKBNETWOR-84: DSLite feature integration with WanManager (Wg network…

[devinmungan]

…11 development)

• RDKBNETWOR-85 : DHCP Manager changes for option 64

• pass received endpoint name to wanmanager via rbus publish

[Copilot]

Pull request overview

This PR integrates the DSLite feature with WanManager by renaming the AFTR (Access Gateway for DS-Lite) field to the more generic endpointName throughout the DHCPv6 handling code, and adds support for passing the received endpoint name to WanManager via RBUS publish.

• Refactored AFTR field to endpointName across DHCPv6 structures and processing functions
• Added a trim() utility function to clean whitespace from endpoint names
• Updated DHCPv6 lease comparison logic to include endpoint name validation

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
source/TR-181/middle_layer_src/dhcpmgr_rbus_apis.c	Added endpointName field copying to DHCP_MGR_IPV6_MSG structure for RBUS event publishing
source/DHCPMgrUtils/dhcpmgr_v6_lease_handler.c	Updated lease comparison function to compare endpointName instead of aftr field
source/DHCPClientUtils/DHCPv6Client/dhcpv6_interface.h	Renamed AFTR_NAME_LENGTH to ENDPOINT_NAME_LENGTH and aftr field to endpointName in DHCPv6_PLUGIN_MSG structure
source/DHCPClientUtils/DHCPv6Client/dhcpmgr_dibbler_plugin/dhcpmgr_dibbler_plugin.c	Added trim function for string cleanup, updated DHCPv6 option 64 handling to use endpointName with trimming, and updated log messages

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

source/TR-181/middle_layer_src/dhcpmgr_rbus_apis.c:338

• getDataHandler reads pDhcpc->currentLease (and later dereferences it) without taking pDhcpc->mutex. currentLease is freed/replaced in the lease-processing path under that mutex, so this can race and potentially dereference freed memory. Acquire the client mutex around the currentLease check and the lease copy into leaseInfo.

    if (!pDhcpc || !pDhcpc->currentLease)
    {
        // Boot case: no lease yet, return invalid/empty
        DHCPMGR_LOG_INFO("%s %d - No current lease for index %d\n", __FUNCTION__, __LINE__, iDmIndex);
        return RBUS_ERROR_SUCCESS;
    }

source/TR-181/middle_layer_src/dhcpmgr_rbus_apis.c:270

• DhcpMgr_MaptParseOpt95Response is called here, but the MAP parsing API was renamed to DhcpMgr_MapParseOptResponse in dhcpmgr_map_apis.h/.c. This looks like a build break (undefined reference / implicit declaration). Update this call (and any others) to the new function name/signature.

        unsigned char  maptContainer[BUFLEN_256] = {0}; /* MAP-T option 95 in hex format*/
        memset(maptContainer, 0, sizeof(maptContainer));
        memcpy(maptContainer, src->mapt.Container, sizeof(src->mapt.Container));
        if (DhcpMgr_MaptParseOpt95Response(dest->sitePrefix, maptContainer, &dest->map) == ANSC_STATUS_SUCCESS)
        {
            dest->maptAssigned = TRUE;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.