RDKB-63681: Move DHCP option43 and option60 related changes to the Hal layer#76
Merged
hpatel006c merged 21 commits intordkcentral:developfrom Feb 27, 2026
Merged
Conversation
Reason for change:preparing custom options for 43 and 60 Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:preparing custom options for 43 and 60 Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:preparing custom options for 43 and 60 Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Adding get handler for Device.DHCPv4.Client.%d.Events Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Getting the supported codecs of option 60 Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Adding the get handler Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Adding the get handler Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change: Voice DHCP No Response with PacketCable Supported Codecs Length = 3 Test Procedure: Voice testing Risks: NA Priority: P1
Reason for change:Option 60, codec, mibs changes Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:DHCPv4.Client.2.Status is not correct Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Enable the debug logs Test Procedure: verify the logic and functionality Risks: Low Priority: P1
Reason for change:Move DHCP option related changes to the HAL Test Procedure: verify the logic and functionality Risks: High Priority: P1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to relocate DHCPv4 option 43/60 (voice/MTA-related) logic out of DHCPMgrUtils and into the HAL layer, simplifying the CustomOptions library and build configuration.
Changes:
- Removed the voice custom options implementation file and its inclusion in the CustomOptions build.
- Dropped the
--enable-voice_mta_supportconfigure option / automake conditional. - Enabled udhcpc plugin file-logging debug macros by default.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/DHCPMgrUtils/CustomOptions/dhcpmgr_voice_custom_options.c |
Deleted the existing voice-specific implementations for DHCP option 43/60 generation. |
source/DHCPMgrUtils/CustomOptions/Makefile.am |
Stops compiling the removed voice custom options source into libcustomoptions. |
source/DHCPClientUtils/DHCPv4Client/dhcpmgr_udhcpc_plugin/dhcpmgr_udhcpc.c |
Switches plugin log redirection block from disabled to enabled. |
configure.ac |
Removes the voice_mta_support configure flag and VOICE_MTA_SUPPORT conditional. |
Comments suppressed due to low confidence (1)
source/DHCPClientUtils/DHCPv4Client/dhcpmgr_udhcpc_plugin/dhcpmgr_udhcpc.c:13
- This change enables the plugin log redirection block unconditionally (#if 1), causing every DHCPMGR_LOG_* call in this plugin to append to /rdklogs/logs/DHCPMGRLog.txt.0. That can significantly increase I/O and log volume in production, and the comment now contradicts the behavior (“Uncomment ... to enable”). Please keep logging disabled by default (or gate it behind a build flag/runtime setting) and update the comment accordingly.
#if 1 // Uncomment the following code to enable plugin logs
#define PLUGIN_DBG_PRINT(fmt ...) {\
FILE *fp = NULL;\
fp = fopen ( "/rdklogs/logs/DHCPMGRLog.txt.0", "a+");\
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Amaresh-Kotekal
force-pushed
the
develop
branch
from
6e31dbc to
9f6f1b2
Compare
hpatel006c
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Move DHCP option related changes to the HAL
Test Procedure: verify the logic and functionality
Risks: High
Priority: P1