RDKB-63242 : [epon-manager development ] hal integration#5
Merged
S-Parthiban-Selvaraj merged 12 commits intomainfrom Feb 16, 2026
Merged
RDKB-63242 : [epon-manager development ] hal integration#5S-Parthiban-Selvaraj merged 12 commits intomainfrom
S-Parthiban-Selvaraj merged 12 commits intomainfrom
Conversation
…t include paths in Makefiles
Updated all HAL API calls in eponMgr_data.c: epon_hal_init() epon_hal_get_link_stats() epon_hal_get_transceiver_stats() epon_hal_get_llid_info() epon_hal_get_interface_list() epon_hal_get_olt_info() epon_hal_get_manufacturer_info() epon_hal_get_link_info() epon_hal_set_oam_log_mask() dpoe_hal_get_cpe_mac_table() Updated function declarations in eponMgr_data.h: eponMgr_data_hal_init() - return type changed to epon_hal_return_t eponMgr_data_set_oam_log_level() - return type changed to epon_hal_return_t 2. HAL Callback Signature Updates Fixed alarm callback in eponMgr_controller.c line 110: Changed from epon_alarm_info_t *alarm_info to const epon_alarm_info_t *alarm_info 3. Added HAL Deinitialization Added epon_hal_deinit() call in eponMgr_controller.c:776 in the eponMgr_controller_destroy() function This ensures proper HAL cleanup when the controller exits 4. Mock HAL Updates (epon_hal_mock.c) Updated all mock function return types from int to epon_hal_return_t Added new epon_hal_deinit() mock implementation for testing
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the EPON HAL library as an external dependency and updates function signatures to use the proper epon_hal_return_t return type throughout the codebase.
Changes:
- Updated HAL function return types from
inttoepon_hal_return_tfor type safety - Added new
epon_hal_deinit()function implementation in the mock HAL - Removed
epon_hal.hfrom local headers and added external include path configuration - Added proper HAL deinitialization in controller cleanup sequence
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/hal_mock/epon_hal_mock.c | Updated return types to epon_hal_return_t and added epon_hal_deinit() implementation |
| tests/hal_mock/Makefile.am | Added external EPON HAL include path |
| src/rbus/Makefile.am | Added external EPON HAL include path |
| src/core/stats_poller/Makefile.am | Added external EPON HAL include path |
| src/core/data_structures/eponMgr_data.h | Updated function signatures to return epon_hal_return_t |
| src/core/data_structures/eponMgr_data.c | Updated variable types and function signatures to use epon_hal_return_t |
| src/core/data_structures/Makefile.am | Added external EPON HAL include path |
| src/core/controller/eponMgr_controller.c | Updated callback signature and added HAL deinitialization call |
| src/core/controller/Makefile.am | Added external EPON HAL include path |
| src/core/Makefile.am | Added external EPON HAL include path |
| include/Makefile.am | Removed local epon_hal.h header file |
| design_docs/06_Configuration.md | Removed ccsp-common-library from dependencies list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ndex and updating parameter paths
…eventExitStatus for Rogers partner
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/rbus/wanmanager_update/eponMgr_wanmanager_update.c:231
- Casting
uint32_ttointcould lead to incorrect behavior if the number of entries exceedsINT_MAX. Consider usinguint32_tfornum_entriesand updating the loop variable accordingly, or add validation to ensure the value is within acceptable range.
int num_entries = (int)rbusValue_GetUInt32(count_value);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…estartPreventExitStatus for Rogers partner" This reverts commit d6728c4.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rfaces" This reverts commit bd97d8c.
guto86
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR integrates the EPON HAL library as an external dependency and updates function signatures to use the proper
epon_hal_return_treturn type throughout the codebase.Changes:
inttoepon_hal_return_tfor type safetyepon_hal_deinit()function implementation in the mock HALepon_hal.hfrom local headers and added external include path configuration