RDKEMW-13782 : Drop root disable #548
Open
adrojaankur wants to merge 1 commit intosupport/8.3.4.0from
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto recipe for Telemetry to stop defining a compile-time flag related to dropping root privileges.
Changes:
- Removed the
-DDROP_ROOT_PRIVCFLAGS define from the Telemetry bitbake recipe.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -24,8 +24,6 @@ CFLAGS += " -Wall -Werror -Wextra" | |||
|
|
|||
There was a problem hiding this comment.
Removing the -DDROP_ROOT_PRIV compile flag likely changes Telemetry’s runtime privilege behavior (based on the name). If this is meant to disable dropping privileges for a specific platform/debug scenario, please gate it behind a build-time feature (e.g., DISTRO_FEATURES/PACKAGECONFIG/MACHINE_FEATURES) and add a short comment explaining when and why it should be disabled, so it doesn’t silently regress security posture for other builds.
Suggested change
| # Ensure Telemetry drops root privileges by default at runtime. | |
| # Platforms that intentionally need to run Telemetry without dropping root | |
| # (e.g., specific debug or constrained environments) may add | |
| # 'disable-drop-root-priv' to DISTRO_FEATURES to omit -DDROP_ROOT_PRIV. | |
| CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'disable-drop-root-priv', '', '-DDROP_ROOT_PRIV', d)}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.