RDK-60652 : Integrate chronyd by sindhu-krishnan · Pull Request #561 · rdkcentral/meta-rdk

sindhu-krishnan · 2026-02-13T12:16:58Z

Reason for change: Integrate chronyd for Time synchronization

Test Procedure: Validate chronyd behaviour
Risks: Low
Priority: P1
Signed-off-by: Sindhuja Sindhuja_Muthukrishnan@comcast.com

Copilot

Pull request overview

Integrates chronyd into the Yocto build to provide time synchronization, including default chrony configuration, a systemd service unit, and a volatile bind for runtime-updated server settings.

Changes:

Added default /etc/chrony.conf and a runtime-updated include file (/etc/rdk_chrony.conf).
Added a chronyd.service systemd unit to start chronyd.
Updated distro config to bind-mount the runtime chrony server config from a volatile path.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
recipes-support/chrony/files/rdk_chrony.conf	Adds RDK-specific NTP server config intended to be updated dynamically.
recipes-support/chrony/files/chronyd.service	Introduces a systemd unit to run `chronyd` at boot.
recipes-support/chrony/files/chrony.conf	Provides base chrony defaults and includes the dynamic RDK config file.
recipes-support/chrony/chrony_%.bbappend	Installs the new config files and service unit into the image/package.
conf/distro/rdk.conf	Adds a volatile bind mount for the dynamic chrony server configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

recipes-support/chrony/chrony_%.bbappend

recipes-support/chrony/files/chronyd.service

conf/distro/rdk.conf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T12:32:28Z

recipes-support/chrony/files/chrony.conf

+logchange 0.5
+
+#Logging
+logdir /opt/logs/chrony


The config sets logdir /opt/logs/chrony, but neither the recipe nor the service ensures this directory exists. If the directory is missing at boot, chronyd logging can fail (and may prevent startup depending on chronyd settings). Create /opt/logs/chrony during install (or via tmpfiles.d) and/or in ExecStartPre.

Suggested change

logdir /opt/logs/chrony

logdir /var/log/chrony

recipes-support/chrony/files/chronyd.service

Copilot · 2026-02-13T12:32:30Z

recipes-support/chrony/chrony_%.bbappend

+    rm ${D}${sysconfdir}/chrony.conf 
+    install -m 755 ${WORKDIR}/chrony.conf ${D}${sysconfdir}/
+    install -m 755 ${WORKDIR}/rdk_chrony.conf ${D}${sysconfdir}/
+
+    # service to start chrony
+    rm ${D}${systemd_unitdir}/system/chronyd.service


The rm commands in do_install:append() are not using -f. If the upstream recipe changes paths or the files are not present for a given build configuration, the build will fail here. Use a non-fatal removal (e.g., rm -f) or guard with a file-exists check.

Suggested change

rm ${D}${sysconfdir}/chrony.conf

install -m 755 ${WORKDIR}/chrony.conf ${D}${sysconfdir}/

install -m 755 ${WORKDIR}/rdk_chrony.conf ${D}${sysconfdir}/

# service to start chrony

rm ${D}${systemd_unitdir}/system/chronyd.service

rm -f ${D}${sysconfdir}/chrony.conf

install -m 755 ${WORKDIR}/chrony.conf ${D}${sysconfdir}/

install -m 755 ${WORKDIR}/rdk_chrony.conf ${D}${sysconfdir}/

# service to start chrony

rm -f ${D}${systemd_unitdir}/system/chronyd.service

vbabypublic

Hope the below settings in chronyd.service is a temporary solution for testing

 Conflicts=systemd-timesyncd.service

We should have a proper solution for mutually exclusive use of chronyd and timesyncd

Could you fill below ticket with the details for review with OSS governance team?

rdkcentral/meta-rdk-oss-reference#353

rebase

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T13:04:29Z

recipes-support/chrony/chrony_%.bbappend

+CONFFILES:${PN} += "${sysconfdir}/chrony.conf"
+CONFFILES:${PN} += "${sysconfdir}/rdk_chrony.conf"


CONFFILES points at ${sysconfdir}/default/chrony.conf, but this bbappend installs the config to ${sysconfdir}/chrony.conf. This means the installed chrony.conf won’t be treated as a conffile (and the referenced conffile path likely doesn’t exist), which can lead to config being overwritten on upgrade. Update CONFFILES to match the actual installed path (and include ${sysconfdir}/chrony.conf).

Suggested change

CONFFILES:${PN} += "${sysconfdir}/chrony.conf"

CONFFILES:${PN} += "${sysconfdir}/rdk_chrony.conf"

CONFFILES:${PN} = "${sysconfdir}/chrony.conf \

${sysconfdir}/rdk_chrony.conf"

Copilot · 2026-02-16T13:04:30Z

recipes-support/chrony/files/chronyd.service

+Type=forking
+PIDFile=/run/chrony/chronyd.pid
+ExecStartPre=/bin/mkdir -p /var/lib/chrony
+ExecStart=/usr/sbin/chronyd  


ExecStart=/usr/sbin/chronyd has trailing whitespace. This can cause noisy diffs and occasionally trips linters; remove the extra spaces.

Suggested change

ExecStart=/usr/sbin/chronyd

ExecStart=/usr/sbin/chronyd

conf/distro/rdk.conf

maniselva006c · 2026-02-24T17:07:00Z

recipes-support/chrony/chrony_%.bbappend

@@ -0,0 +1,38 @@
+FILESEXTRAPATHS:prepend := "${THISDIR}/files:"


does this change affect the dependent module like systime manager ?

This NTP client change does not impact SystimeMgr. Deep sleep will be handled in Systimemgr in later changes. There are no other dependencies.

maniselva006c · 2026-02-24T17:09:33Z

recipes-support/chrony/chrony_%.bbappend

+FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
+
+
+SRC_URI += "file://chrony.conf \


are the any service in RDKE stack that depends on systemd-timesyncd ?

recipes-support/chrony/files/rdk_chrony.conf

maniselva006c · 2026-02-24T17:14:39Z

recipes-support/chrony/chrony_%.bbappend

+    install -m 0644 ${WORKDIR}/chronyd.service ${D}${systemd_unitdir}/system/
+
+}
+


These files should be moved to oss repo

vbabypublic · 2026-02-24T18:08:32Z

Hi Deva, Sindhuja,

As the current PR rdkcentral/meta-rdk#561 meant as a temporary solution, can we discuss/decide on following ?

(1) The next OSS release 4.11.0 is planned on Friday, February 27. Do you need to move the bbappend in meta-rdk to meta-rdk-oss-reference and include in this release? If so, could you create a PR for that ?

(2) Please find the review comments in the PR. The content of bbappend cannot be fully move to meta-rdk-oss-reference due to sensitive URLs (server time.xfinity.com). Even it cannot be kept in meta-rdk since it is a public repository

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T11:49:03Z

recipes-support/chrony/files/chronyd.service

+[Unit]
+Description=NTP client/server
+Documentation=man:chronyd(8) man:chrony.conf(5)
+After=var-lib.mount nvram.service


The service is set to WantedBy=network-up.target but doesn't have any explicit network dependency in the After= directive (e.g., network-online.target or network.target). This could cause chronyd to start before the network is ready, leading to initial NTP sync failures. Consider adding "After=network-online.target" or a similar network dependency to ensure the network is available before chronyd starts.

Suggested change

After=var-lib.mount nvram.service

After=network-online.target var-lib.mount nvram.service

Copilot · 2026-02-25T11:49:03Z

recipes-support/chrony/chrony_%.bbappend

+    install -m 0755 ${S}/chronyc ${D}${sbindir}
+
+    #config File
+    rm ${D}${sysconfdir}/chrony.conf 


This line has trailing whitespace after the command. Remove the trailing space to maintain code cleanliness.

Suggested change

rm ${D}${sysconfdir}/chrony.conf

rm ${D}${sysconfdir}/chrony.conf

Copilot · 2026-02-25T11:49:03Z

recipes-support/chrony/chrony_%.bbappend

+    # Binaries
+    install -m 0755 ${S}/chronyc ${D}${sbindir}
+
+    #config File


Comment formatting is inconsistent. Line 10 uses "# Binaries" (with space after #), while this line uses "#config File" (no space after #). For consistency, use a space after # as seen in other comments in this file.

Suggested change

#config File

# Config File

Copilot · 2026-02-25T11:49:04Z

recipes-support/chrony/chrony_%.bbappend

+do_install:append() {
+    # Binaries
+    install -m 0755 ${S}/chronyc ${D}${sbindir}


The chrony.conf specifies "logdir /opt/logs/chrony" but the do_install function does not create this directory. This may cause chronyd to fail at runtime if the directory doesn't exist. Consider adding a command like "install -d ${D}/opt/logs/chrony" in the do_install:append function.

Copilot · 2026-02-25T11:49:04Z

recipes-support/chrony/files/rdk_chrony.conf

@@ -0,0 +1,2 @@
+# Configuration values in this file may change dynamically via TR-181 parameters.
+


The server configuration uses "time.xfinity.com" which is a Comcast/Xfinity-specific NTP server. The comment on line 1 states "Configuration values in this file may change dynamically via TR-181 parameters," but hardcoding a partner-specific server here may not be appropriate for all deployments. Consider using a more generic default server or making this configurable during build time.

Suggested change

# Use a generic public NTP pool by default; deployments may override this via TR-181 or at build time.

server pool.ntp.org iburst

Copilot · 2026-02-25T11:49:04Z

recipes-support/chrony/files/chrony.conf

+#Configuration values in this file are defaults and typically do not change.
+#Server configurations are added at runtime as it may change based on the partner.
+
+# The next option causes a message to be written to syslog when chronyd
+# has to correct an error above 0.5 seconds (you can use any amount you
+# like).
+logchange 0.5
+
+#Logging
+logdir /opt/logs/chrony
+log measurements statistics tracking
+
+# Step the system clock instead of slewing it if the adjustment is larger than
+# one second, but only in the first three clock updates.
+makestep 1.0 3
+
+
+#Record the rate at which the system clock gains/losses time.


Comment formatting is inconsistent. Lines 1, 9, and 18 use "#" without a space after it, while lines 4-6, 13-14, 21-23, and 26 use "# " with a space. For consistency, use a space after # in comments.

sindhu-krishnan added 5 commits February 13, 2026 17:38

Update rdk.conf

8403ab2

Create chrony_%.bbappend

57caa0c

Create chrony.conf

b956644

Create chronyd.service

3f862fe

Create rdk_chrony.conf

093ba86

sindhu-krishnan requested review from a team as code owners February 13, 2026 12:16

Copilot AI review requested due to automatic review settings February 13, 2026 12:16

Copilot started reviewing on behalf of sindhu-krishnan February 13, 2026 12:17 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

recipes-support/chrony/chrony_%.bbappend Outdated Show resolved Hide resolved

recipes-support/chrony/chrony_%.bbappend Outdated Show resolved Hide resolved

recipes-support/chrony/files/chronyd.service Show resolved Hide resolved

conf/distro/rdk.conf Outdated Show resolved Hide resolved

Apply suggestion from @Copilot

72569cd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 12:27

Copilot started reviewing on behalf of sindhu-krishnan February 13, 2026 12:27 View session

Update rdk_chrony.conf

a948af1

Copilot AI reviewed Feb 13, 2026

View reviewed changes

vbabypublic reviewed Feb 13, 2026

View reviewed changes

sindhu-krishnan mentioned this pull request Feb 16, 2026

Chronyd instead of systemd-timesyncd rdkcentral/meta-rdk-oss-reference#353

Open

sindhu-krishnan and others added 2 commits February 16, 2026 15:24

Merge pull request #567 from rdkcentral/develop

f39033a

rebase

Apply suggestion from @Copilot

c49bf2e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 16, 2026 12:56

Copilot started reviewing on behalf of sindhu-krishnan February 16, 2026 12:56 View session

Apply suggestion from @Copilot

f505ddc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Feb 16, 2026

View reviewed changes

maniselva006c reviewed Feb 24, 2026

View reviewed changes

conf/distro/rdk.conf Outdated Show resolved Hide resolved

maniselva006c reviewed Feb 24, 2026

View reviewed changes

recipes-support/chrony/files/rdk_chrony.conf Outdated Show resolved Hide resolved

maniselva006c reviewed Feb 24, 2026

View reviewed changes

Update rdk.conf

36c0c21

Copilot AI review requested due to automatic review settings February 25, 2026 11:42

Copilot started reviewing on behalf of sindhu-krishnan February 25, 2026 11:42 View session

Update rdk_chrony.conf

938c930

Copilot AI reviewed Feb 25, 2026

View reviewed changes

		CONFFILES:${PN} += "${sysconfdir}/chrony.conf"
		CONFFILES:${PN} += "${sysconfdir}/rdk_chrony.conf"

		@@ -0,0 +1,38 @@
		FILESEXTRAPATHS:prepend := "${THISDIR}/files:"

		FILESEXTRAPATHS:prepend := "${THISDIR}/files:"


		SRC_URI += "file://chrony.conf \

		install -m 0644 ${WORKDIR}/chronyd.service ${D}${systemd_unitdir}/system/

		}

	After=var-lib.mount nvram.service
	After=network-online.target var-lib.mount nvram.service

	rm ${D}${sysconfdir}/chrony.conf
	rm ${D}${sysconfdir}/chrony.conf

		@@ -0,0 +1,2 @@
		# Configuration values in this file may change dynamically via TR-181 parameters.


	# Use a generic public NTP pool by default; deployments may override this via TR-181 or at build time.
	server pool.ntp.org iburst

Conversation

sindhu-krishnan commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

vbabypublic left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maniselva006c Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

sindhu-krishnan Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

maniselva006c Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maniselva006c Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

vbabypublic commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

vbabypublic commented Feb 24, 2026 •

edited

Loading