RDKEMW-4789 Replace rfc with rbus from libunpriv component

[madhubabutt]

No description provided.

[Copilot]

Pull request overview

This pull request updates the libunpriv component to replace RFC with rbus as a dependency. The changes align with the RDKEMW-4789 initiative to migrate from RFC to rbus for this component.

Changes:

• Added rbus as a build dependency alongside existing libcap and jsoncpp dependencies
• Updated SRCREV to point to a new commit that contains the rbus integration code
• Added rbus include paths and linker flags to enable compilation and linking against rbus

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The syntax LDFLAGS_append is deprecated. Use LDFLAGS:append instead to match the modern BitBake syntax used consistently throughout the codebase (e.g., line 12 uses CXXFLAGS:append).

Suggested change

	LDFLAGS_append = " \
	LDFLAGS:append = " \

[Copilot]

The include path syntax -I=${includedir}/rbus is inconsistent with other recipes that depend on rbus. For example, webconfig-framework.bb uses -I${STAGING_INCDIR}/rbus (webconfig-framework.bb:30). Consider using -I${STAGING_INCDIR}/rbus for consistency with the codebase pattern.

Suggested change

	-I=${includedir}/rbus \
	-I${STAGING_INCDIR}/rbus \

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The rbus include path is added using -I=${includedir}/rbus while the rest of this recipe uses ${STAGING_INCDIR} for include paths. Mixing these can be fragile across toolchains/sysroot handling; consider switching to a sysroot-staged path (e.g., ${STAGING_INCDIR}/rbus) or using the same sysroot-aware pattern used elsewhere in the layer (via $(PKG_CONFIG_SYSROOT_DIR)${includedir}/rbus) to keep header resolution consistent.

Suggested change

	-I=${includedir}/rbus \
	-I${STAGING_INCDIR}/rbus \

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The include path should use ${STAGING_INCDIR}/rbus instead of ${includedir}/rbus to be consistent with other include paths in this recipe (lines 13-14) and with how rbus include paths are specified in other recipes like webconfig-framework.bb. The ${STAGING_INCDIR} variable points to the staging directory where headers from dependencies are installed during the build, while ${includedir} refers to the final installation directory on the target system, which is incorrect for compiler flags during the build process.

Suggested change

	-I${includedir}/rbus"
	-I${STAGING_INCDIR}/rbus"

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.