Conversation
Reason for change: Update libsyswrapper.bb with SHA
There was a problem hiding this comment.
Pull request overview
Updates the Yocto recipe for libSyscallWrapper to point to a newer upstream Git commit, presumably containing the Coverity-related fixes, by changing the pinned SRCREV.
Changes:
- Update
SRCREVinlibsyswrapper.bbto a newer commit SHA.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DEPENDS += "rdk-logger" | ||
| SRCREV = "5143ba5b92f5dc77b436837d51f2f612d5846b7b" | ||
| SRCREV = "7fa1b7ace6e314b83f14db028ef511a67cfa6037" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/libSyscallWrapper;${CMF_GITHUB_SRC_URI_SUFFIX};name=libsyswrapper" |
There was a problem hiding this comment.
Changing SRCREV updates the fetched source but leaves the produced package version unchanged (since PV/PR are unchanged). In feeds/upgrade scenarios this can result in devices not picking up the new build because the package version string stays the same. Please bump the recipe revision (PR) (or alternatively incorporate SRCPV into PV) when updating SRCREV so the package version changes alongside the source.
Rebase with develop
Reason for change: Updated srcrev to consume the PR changes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PR = "r0" | ||
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||
| SRCREV_rdk-libunpriv = "547d202d421ed83bd60b677b5d057cad3b7ae8ad" | ||
| SRCREV_rdk-libunpriv = "810b357f41605d9c3e09d2c47f9f3365da1b3b76" |
There was a problem hiding this comment.
The PR title mentions "Fix Coverity issues" and indicates updates to both libsyswrapper.bb and libunpriv.bb, but the PR description only mentions "Update libsyswrapper.bb with SHA". The description should be updated to reflect that both libsyswrapper.bb and libunpriv.bb are being updated, or the title should clarify which files are being updated.
RDKEMW-4941 : bcm bb/bbappend analysis for bluetooth-mgr (#566)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RDKEMW-14300 : Pull RDKLogger latest to get all features of v3.1.0 (#…
Rebase with develop
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Update libsyswrapper.bb with SHA